Commit Graph

115547 Commits

Author SHA1 Message Date
Hugues Peccatte
59d720d7dd Remove useless method parameter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
158a13828f Remove useless unset
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
50bcfc8ed6 Remove useless attribute
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
e2f66cf9e4 Remove $text_dir global from PHPStan ignored errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 16:04:16 -03:00
Maurício Meneghini Fauth
f19ab9a0b0 Remove $pmaThemeImage global from ignored errors for PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 15:37:19 -03:00
Maurício Meneghini Fauth
82a03931d6 Remove $table global from ignored errors for PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 15:17:57 -03:00
Maurício Meneghini Fauth
45546661aa Remove $db from ignore errors for PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 14:54:21 -03:00
Maurício Meneghini Fauth
6aeccaada7 Ignore $cfg only in ConfigTest and PmaTestCase
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 14:10:15 -03:00
Maurício Meneghini Fauth
94a18417ee Declare $cfg global variable explicitly
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 13:03:23 -03:00
Maurício Meneghini Fauth
720e302de5
Merge pull request #15264 from Tithugues/fix/property-visibility
Fix property visibility
2019-05-13 17:13:16 -03:00
William Desportes
65b619c5a8
Merge branch 'QA_4_8'
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-12 00:41:11 +02:00
William Desportes
4b2a957123
Add ChangeLog entry for 47bd88dff
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-12 00:39:06 +02:00
William Desportes
47bd88dffa
Add support for auto-increment on ROCKSDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 23:53:07 +02:00
Maurício Meneghini Fauth
079cb8dcc0
Merge pull request #15265 from Tithugues/feature/sort-dependencies-in-composer-json
Sort dependencies in composer.json
2019-05-11 18:46:34 -03:00
Hugues Peccatte
9da8ee3821 Sort dependencies in composer.json
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 22:16:20 +02:00
Hugues Peccatte
c88964caac Fix property visibility
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 21:48:12 +02:00
Maurício Meneghini Fauth
cafd4b3ee6 Upgrade sql-parser to version 5.0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-11 15:33:39 -03:00
Maurício Meneghini Fauth
45e923d9bd
Merge pull request #15259 from Tithugues/fix/remove-unexisting-or-useless-variables
Remove use of unexisting / useless variables
2019-05-10 20:51:24 -03:00
William Desportes
609f9fd871
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:55:15 +02:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:53:57 +02:00
Hugues Peccatte
5f44cd3b68 Remove comment
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 00:36:49 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 00:34:57 +02:00
William Desportes
450fdab3d0
Fix export on designer page (use POST instead of GET)
Affects the file name when exporting
Introduced-by: 3500da154f
[ci-skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:15:10 +02:00
Maurício Meneghini Fauth
45dc342666 Fix coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-10 19:07:02 -03:00
William Desportes
31ab2cb4e8
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:03:16 +02:00
Isaac Bennetch
9753b24e44 ChangeLog for pull request #15246
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-05-10 13:11:47 -04:00
Isaac Bennetch
de01bc333f Standardized spelling/styling of phpMyAdmin name
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-05-10 13:06:12 -04:00
Isaac Bennetch
191d0485b6
Merge pull request #15246 from williamdes/bugfix/issue-14412-auth-signon
Fix #14412 - AuthenticationSignon.php's showFailure function does not consider SignonCookieParams
2019-05-10 13:03:23 -04:00
Dhruv Gupta
0db80bf132 [REFACTOR] Removed unused variables and added file description comments (#15173)
Signed-off-by: Dhruv Gupta <gdhruv167@gmail.com>
2019-05-08 23:22:07 -03:00
Maurício Meneghini Fauth
422cd3ade2
Merge pull request #15258 from Tithugues/feature/use-strpos-instead-of-strstr
Use "strpos" instead of "strstr" to improve performances
2019-05-08 14:20:45 -03:00
Maurício Meneghini Fauth
ad2c698650
Merge pull request #15257 from Tithugues/feature/useless-i-modifier
Remove useless "i" modifier on non-character selection
2019-05-08 14:19:00 -03:00
Maurício Meneghini Fauth
620afff0ea
Merge pull request #15256 from Tithugues/feature/replace-regexp-by-replace
Replace regexp by str_replace when possible
2019-05-08 14:18:06 -03:00
Maurício Meneghini Fauth
e0c3f09a33
Merge pull request #15253 from Tithugues/feature/change-tbl-partition-definition-include-as-a-class
Change "tbl_partition_definition.inc.php" file as a class
2019-05-08 14:16:13 -03:00
Maurício Meneghini Fauth
53dc1ff844
Merge pull request #15245 from Tithugues/feature/change-error-include-as-a-class
Change "error.inc.php" file as a class
2019-05-08 13:03:36 -03:00
Maurício Meneghini Fauth
5b9ad4ebd3
Merge pull request #15255 from Tithugues/feature/replace-class-name-as-string
Replace class name as string by ":class"
2019-05-07 23:15:37 -03:00
Maurício Meneghini Fauth
4adc7a2c4c
Merge pull request #15254 from Tithugues/feature/use-magic-variables-when-possible
Use magic variables when possible
2019-05-07 22:33:17 -03:00
Hugues Peccatte
69895e4bb1 Use "strpos" instead of "strstr" to improve performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:58:05 +02:00
Hugues Peccatte
d28894d9ba Change "tbl_partition_definition.inc.php" file as a class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:29:30 +02:00
Hugues Peccatte
3470dd4918 Remove useless "i" modifier on non-character selection
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:27:18 +02:00
Hugues Peccatte
fc1ffb1413 Replace regexp by str_replace when possible
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:26:01 +02:00
Hugues Peccatte
052e22c1a6 Use magic variables when possible
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 22:59:13 +02:00
Hugues Peccatte
4b628b6553 Replace class name as string by ":class"
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 22:56:59 +02:00
William Desportes
3500da154f
Fix undefined index dialog
Did occur when POST OR GET was sent to have a dialog
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 18:45:51 +02:00
William Desportes
0b9aad74e4
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 14:23:08 +02:00
William Desportes
3e3a5ce7e2
Fix failing tests for #14588
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 14:14:21 +02:00
William Desportes
d19bc53626
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 13:52:08 +02:00
William Desportes
335ae4fe13
Fix #14588 - export all geometry objects as hex
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 13:47:37 +02:00
William Desportes
b50a85bb04
Fix #14588 - export all geometry objects as hex (ODS, ODT)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 13:47:37 +02:00
William Desportes
928febd9a3
Add ChangeLog entry for #14588
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 12:39:29 +02:00
William Desportes
7f454ac590
Fix #14588 - export all geometry objects as hex
Fixes: #14588
Export all geometry objects as hex
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 12:35:53 +02:00