Commit Graph

115527 Commits

Author SHA1 Message Date
William Desportes
609f9fd871
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:55:15 +02:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:53:57 +02:00
William Desportes
450fdab3d0
Fix export on designer page (use POST instead of GET)
Affects the file name when exporting
Introduced-by: 3500da154f
[ci-skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:15:10 +02:00
Maurício Meneghini Fauth
45dc342666 Fix coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-10 19:07:02 -03:00
William Desportes
31ab2cb4e8
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:03:16 +02:00
Isaac Bennetch
9753b24e44 ChangeLog for pull request #15246
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-05-10 13:11:47 -04:00
Isaac Bennetch
de01bc333f Standardized spelling/styling of phpMyAdmin name
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-05-10 13:06:12 -04:00
Isaac Bennetch
191d0485b6
Merge pull request #15246 from williamdes/bugfix/issue-14412-auth-signon
Fix #14412 - AuthenticationSignon.php's showFailure function does not consider SignonCookieParams
2019-05-10 13:03:23 -04:00
Dhruv Gupta
0db80bf132 [REFACTOR] Removed unused variables and added file description comments (#15173)
Signed-off-by: Dhruv Gupta <gdhruv167@gmail.com>
2019-05-08 23:22:07 -03:00
Maurício Meneghini Fauth
422cd3ade2
Merge pull request #15258 from Tithugues/feature/use-strpos-instead-of-strstr
Use "strpos" instead of "strstr" to improve performances
2019-05-08 14:20:45 -03:00
Maurício Meneghini Fauth
ad2c698650
Merge pull request #15257 from Tithugues/feature/useless-i-modifier
Remove useless "i" modifier on non-character selection
2019-05-08 14:19:00 -03:00
Maurício Meneghini Fauth
620afff0ea
Merge pull request #15256 from Tithugues/feature/replace-regexp-by-replace
Replace regexp by str_replace when possible
2019-05-08 14:18:06 -03:00
Maurício Meneghini Fauth
e0c3f09a33
Merge pull request #15253 from Tithugues/feature/change-tbl-partition-definition-include-as-a-class
Change "tbl_partition_definition.inc.php" file as a class
2019-05-08 14:16:13 -03:00
Maurício Meneghini Fauth
53dc1ff844
Merge pull request #15245 from Tithugues/feature/change-error-include-as-a-class
Change "error.inc.php" file as a class
2019-05-08 13:03:36 -03:00
Maurício Meneghini Fauth
5b9ad4ebd3
Merge pull request #15255 from Tithugues/feature/replace-class-name-as-string
Replace class name as string by ":class"
2019-05-07 23:15:37 -03:00
Maurício Meneghini Fauth
4adc7a2c4c
Merge pull request #15254 from Tithugues/feature/use-magic-variables-when-possible
Use magic variables when possible
2019-05-07 22:33:17 -03:00
Hugues Peccatte
69895e4bb1 Use "strpos" instead of "strstr" to improve performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:58:05 +02:00
Hugues Peccatte
d28894d9ba Change "tbl_partition_definition.inc.php" file as a class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:29:30 +02:00
Hugues Peccatte
3470dd4918 Remove useless "i" modifier on non-character selection
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:27:18 +02:00
Hugues Peccatte
fc1ffb1413 Replace regexp by str_replace when possible
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:26:01 +02:00
Hugues Peccatte
052e22c1a6 Use magic variables when possible
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 22:59:13 +02:00
Hugues Peccatte
4b628b6553 Replace class name as string by ":class"
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 22:56:59 +02:00
William Desportes
3500da154f
Fix undefined index dialog
Did occur when POST OR GET was sent to have a dialog
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 18:45:51 +02:00
William Desportes
0b9aad74e4
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 14:23:08 +02:00
William Desportes
3e3a5ce7e2
Fix failing tests for #14588
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 14:14:21 +02:00
William Desportes
d19bc53626
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 13:52:08 +02:00
William Desportes
335ae4fe13
Fix #14588 - export all geometry objects as hex
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 13:47:37 +02:00
William Desportes
b50a85bb04
Fix #14588 - export all geometry objects as hex (ODS, ODT)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 13:47:37 +02:00
William Desportes
928febd9a3
Add ChangeLog entry for #14588
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 12:39:29 +02:00
William Desportes
7f454ac590
Fix #14588 - export all geometry objects as hex
Fixes: #14588
Export all geometry objects as hex
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 12:35:53 +02:00
William Desportes
bd1a48b3aa
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 10:37:47 +02:00
William Desportes
7233a887da
Fix #15251 - SQL queries > affected lines > -1 > does not show as error
Fixes: #15251
Introduced-by: 4e01371cd251a0f30b26540f22bbda3ea80945feSigned-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 10:34:56 +02:00
Ahmed M. Farrag
0c02aaac42
Translated using Weblate (Arabic)
Currently translated at 48.4% (1596 of 3300 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/ar/
Signed-off-by: Ahmed M. Farrag <a.m.farrag@gmail.com>
2019-05-06 13:48:51 +02:00
Hugues Peccatte
cccd820914 Add Display/ErrorTest class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-05 22:12:29 +02:00
Hugues Peccatte
1819259b84 Change "error.inc.php" file as a class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-05 22:12:29 +02:00
William Desportes
b5245272db
Use ::class for AuthenticationSignon test
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-05 13:48:29 +02:00
William Desportes
1c55346cdb
Add a test for setCookieParams
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-05 13:48:29 +02:00
William Desportes
47c3f131b4
Fix #14412 - AuthenticationSignon.php's showFailure function does not consider SignonCookieParams
Fixes: #14412
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-05 13:48:29 +02:00
Maurício Meneghini Fauth
14da395f75
Merge pull request #15241 from Tithugues/feature/change-user-preferences-include-as-a-class
Change "user_preferences.inc.php" file as a class
2019-05-05 08:17:48 -03:00
Maurício Meneghini Fauth
8112dc8bc7 Add ChangeLog entry for #15072
Fixes #15072
Closes #15114
Closes #15073

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 22:58:42 -03:00
Anton Mokrousov
1bf8123b88 Issue #15072 fix (added button)
Added button "Close" at the bottom of "Monitor instructions" window to make it similar to other dialog windows

Signed-off-by: Anton Mokrousov <settingx@mail.ru>
2019-05-04 22:54:30 -03:00
Maurício Meneghini Fauth
3ec6d02578
Merge pull request #15244 from Tithugues/feature/minor-improvements-on-message-class
Minor improvements in Message class
2019-05-04 19:00:16 -03:00
Maurício Meneghini Fauth
0ccae90725
Merge pull request #15243 from Tithugues/feature/message-in-message-is-self
Message in Message class is self
2019-05-04 18:25:26 -03:00
Hugues Peccatte
d8f9695830 Minor improvements in Message class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:26:26 +02:00
Hugues Peccatte
fb78fa6fc0 Message in Message class is self
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:09:11 +02:00
Maurício Meneghini Fauth
8261661258 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 17:02:46 -03:00
Hugues Peccatte
f5b475fdbd Add UserPreferencesTest
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:02:10 +02:00
Hugues Peccatte
fdfff01083 Change "user_preferences.inc.php" file as a class
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-04 22:02:10 +02:00
Maurício Meneghini Fauth
9de453fa31 Add ChangeLog entry for #14934
Fixed all fields readonly on Edit/Insert screens

- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-04 17:00:48 -03:00
Maurício Meneghini Fauth
b30555f887
Merge pull request #14993 from bahl24/fix-#14934
removed readonly cond as its redundant
2019-05-04 16:57:15 -03:00