Commit Graph

118608 Commits

Author SHA1 Message Date
William Desportes
7b6cf8a1b9
Fix bad mocking cleanup of Response::_instance
Seed: 1590097033

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:40:59 +02:00
William Desportes
1cb874a75e
Make GitTest::testIsGitRevision not depend on .git directory in filesystem
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:34:33 +02:00
William Desportes
bb0bc3bb93
Merge #16131 - Unit test suite improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 23:32:11 +02:00
William Desportes
e964206215
Remove object typehint for php 7.1
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 23:11:45 +02:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
William Desportes
5c270d863d
Move callProtectedFunction to abstract class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 21:58:41 +02:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-21 15:29:36 -03:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
3a49cb33bb
Move defining envs to defineTestingGlobals
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:35:36 +02:00
William Desportes
fe32a359dc
Move PMA_VERSION calls into defineVersionConstants() for tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:26:48 +02:00
William Desportes
f89f4c9f2c
Fix failing tests after tear down cleans everything
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
afc734846d
Tear everything down
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
a330babefd
Fix curl init error condition
Signed-off-by: William Desportes <williamdes@wdes.fr>

curl
2020-05-21 13:19:23 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
a6c469611a
Minor fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
5195520883
Coding standard fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:18:05 +02:00
William Desportes
13eaeadbf9
Clean bootstrap-dist file
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
a7490fcb6c
Make AbstractTestCase manage GLOBALS cleanup and config loading
Signed-off-by: William Desportes <williamdes@wdes.fr>
Some minor improvements

Signed-off-by: William Desportes <williamdes@wdes.fr>

Force sql-parser to reload the new language

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
Maurício Meneghini Fauth
115f79c959 Extract primary action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-20 19:59:55 -03:00
William Desportes
5bc53cc5e5
Set evil backupGlobals to false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:47 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
8624fbbe97
Create AbstractTestCase class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:14:28 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest

Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:10:32 +02:00
William Desportes
5aef97207b
Do not use strict equals with class names
Ref: ec3efe8a1e

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 14:16:03 +02:00
William Desportes
ec3efe8a1e
Use ::class in Plugin class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:50 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
William Desportes
4856ef812d
Use the standard [ci skip] lowercase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 02:32:41 +02:00
William Desportes
10ef81db84
Fix HTML escaping for db and table parameters on "Privileges" page
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 02:28:35 +02:00
William Desportes
1686770212
Fix #16119 - ActionLinksMode icons not showing text on structure page
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 02:23:10 +02:00
Jesper Hertel
6aba79789c
Translated using Weblate (Swedish)
Currently translated at 87.9% (2951 of 3355 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/sv/
Signed-off-by: Jesper Hertel <jesper.hertel@gmail.com>
2020-05-20 02:15:24 +02:00
William Desportes
e117391154
Translated using Weblate (Persian)
Currently translated at 23.6% (793 of 3355 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/fa/
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 02:15:23 +02:00
Dwayne Bailey
5756d11478
Translated using Weblate (Afrikaans)
Currently translated at 8.7% (292 of 3355 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/af/
Signed-off-by: Dwayne Bailey <dwayne@translate.org.za>
2020-05-20 02:15:22 +02:00
Riku Viitanen
73e81f8824
Translated using Weblate (Finnish)
Currently translated at 63.7% (2139 of 3355 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/fi/
Signed-off-by: Riku Viitanen <riku.viitanen@protonmail.com>
2020-05-20 02:15:21 +02:00
Jesper Hertel
22416dff80
Translated using Weblate (Danish)
Currently translated at 94.0% (3156 of 3355 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/da/
Signed-off-by: Jesper Hertel <jesper.hertel@gmail.com>
2020-05-20 02:15:20 +02:00
William Desportes
1f8d3d4e0e
Set Scrutinizer coverage to external
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 02:07:01 +02:00
William Desportes
cdb3629da2
Fix some outdated documentation in our codebase and improve it
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 02:06:31 +02:00
William Desportes
cfc17e56ea
Fix some potential bugs after my last commit
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 01:43:57 +02:00
William Desportes
3db033224e
Add more typehints and improve some code for Util class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 01:43:24 +02:00
William Desportes
a819fa10d4
Use parse_url PHP_URL_PATH instead of parsing all
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 01:19:28 +02:00
William Desportes
4b0985843f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 01:13:58 +02:00
William Desportes
b5012300dc
Add a ChangeLog entry for #16127
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 20:13:00 +02:00
William Desportes
481023e946
Fix #16127 - table column description error when DisableIS=true
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 20:11:53 +02:00
Maurício Meneghini Fauth
04590f5b4f Extract drop fields action from index action
Extracts the /table/structure/drop route from the /table/structure
route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-19 13:37:16 -03:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-19 11:21:42 -03:00
William Desportes
73290bcdcf
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 00:10:11 +02:00
William Desportes
8cea059c83
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 00:03:48 +02:00
William Desportes
02c2f9cd18
Add a ChangeLog entry for #16089
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 00:02:19 +02:00
William Desportes
48c821d08a
Fix #16089 - 2FA UX enhancement, autofocus 2FA input
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 00:01:18 +02:00