Commit Graph

115596 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
842be3898b
Merge pull request #15288 from mauriciofauth/functions-js
Use a module for js/functions.js functions
2019-05-22 18:53:52 -03:00
Maurício Meneghini Fauth
1f62d01470 Use spaceship operator instead of nested ternary operator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 18:43:54 -03:00
Maurício Meneghini Fauth
83f56cdedf Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 18:35:35 -03:00
Maurício Meneghini Fauth
dafc17c52e Add explicit parentheses in nested ternary operators
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 18:32:42 -03:00
Maurício Meneghini Fauth
ce71901de5 Refactor js/functions.js to use a module
Adds Functions module in js/functions.js to reduce the number of global variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 17:44:21 -03:00
Maurício Meneghini Fauth
562b5a48f0 Remove PMA_ from PMA_commonParams and PMA_commonActions names
PMA_commonParams => CommonParams
PMA_commonActions => CommonActions

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-21 00:18:44 -03:00
Maurício Meneghini Fauth
ea2d5a0d87 Rename PMA_messages JS global variable to Messages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-20 23:58:23 -03:00
Nitish Bahl
6049a2739d minor design changes in jqplot-tooptip
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-20 22:34:38 -03:00
Agha Saad Fraz
504ab646b6 Fix15185 Converted JQuery dialog buttons into Bootstrap 4 (#15201)
* Converted JQuery dialog buttons into Bootstrap 4

Signed-off-by: Agha Saad Fraz <agha.saad04@gmail.com>
2019-05-20 21:56:53 -03:00
William Desportes
c1186dcdba
Merge branch 'QA_4_8'
Closes #15280

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-20 14:23:31 +02:00
William Desportes
3002944e24
Add ChangeLog entry for #15262
- Removed a white space
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-20 14:20:05 +02:00
William Desportes
be99ab3a1a
Fix #15262 - Incorrect display of charset column : <dfn title=
Fixes: #15262
Pull-request: #15281
Pull-request: #15280
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-20 14:17:06 +02:00
Technoknol
07e4d7638e
Fix #15262 Incorrect display of charset column : <dfn title=
Signed-off-by: Shyam Makwana <shyam.makwana18@gmail.com>
2019-05-20 14:13:38 +02:00
William Desportes
073169f6f3
Fix key block size (sprintf)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 22:06:19 +02:00
William Desportes
de4bc0751b
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:20:57 +02:00
William Desportes
dceac36518
Add ChangeLog entry for #13854 and 966902b7a5
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:14:58 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:10:57 +02:00
William Desportes
966902b7a5
Add support for virtual columns on PerconaDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:06:27 +02:00
Maurício Meneghini Fauth
1a846baa0f
Merge pull request #15266 from Tithugues/feature/DI
External dependency injection system
2019-05-19 11:55:56 -03:00
Hugues Peccatte
4b2980e01f Fix missing arguments
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 15:38:54 +02:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
2019-05-19 14:10:52 +02:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00
William Desportes
ae39ea5cbd
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 01:14:00 +02:00
William Desportes
35fcea7df6
Fix #14621 - add "Propose table structure" on MariaDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 00:33:11 +02:00
William Desportes
e18f697f27
Add ChangeLog entry for #14621
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 00:14:46 +02:00
William Desportes
1895900e63
Fix #14621 - remove "Propose table structure" on MySQL 8.0
Fixes: #14621
Pull-request: #14697
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 00:10:38 +02:00
Agus Perwira Purnomo
3a8f026ebb
Fix #14621 - "Propose table structure" on MySQL 8.0
Propose table structure link not displayed anymore for MySQL >= 8.0

Cherry-picked-from: ff6ffb1c35491b18e4096472f0419be934ee65c0
Signed-off-by: Agus Perwira Purnomo <furunomail@gmail.com>
2019-05-19 00:02:11 +02:00
William Desportes
acfdc0f41a
Add ChangeLog entry for #15174
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 23:40:45 +02:00
William Desportes
8ccb854c5e
Fix #15174 - Improve Filter method in server variables page
Fixes: #15174
Pull-request: #15179
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 23:39:37 +02:00
William Desportes
7b3bfe5c91
Fix lint error "elseif"
PSR2.ControlStructures.ElseIfDeclaration.NotAllowed

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 22:05:31 +02:00
William Desportes
24c1481cac
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 21:55:31 +02:00
William Desportes
cf55db06e2
Add ChangeLog entry for #14252
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 21:52:02 +02:00
William Desportes
8287ab2ba3
Fix #14252 - DisableIS and database tree list (refresh db list)
Fixes: #14252
Pull-request: #15269
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 21:50:09 +02:00
William Desportes
b7bba700f1
Add ChangeLog entry for #15276
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 21:25:56 +02:00
William Desportes
09d20e8c8d
Fix #15276 - Partitioning is missing in Structure page UI
Fixes: #15276
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-18 21:17:16 +02:00
Maurício Meneghini Fauth
4e5bd7cb85 Remove $sql_query global from PHPStan ignore list
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-16 19:17:58 -03:00
Maurício Meneghini Fauth
1bd73da1d9 Ignore $action only in mult_submits.inc and tbl_columns_definition_form.inc
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-16 16:55:57 -03:00
Maurício Meneghini Fauth
3b1e868fb1
Merge pull request #15260 from Tithugues/feature/cleaning
Feature/cleaning
2019-05-14 23:26:02 -03:00
Maurício Meneghini Fauth
cd4068f525 Remove $server global from PHPStan ignored list
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 22:43:54 -03:00
Maurício Meneghini Fauth
f396dbd7ff Remove some variables from PHPStan ignored list
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 22:34:31 -03:00
Maurício Meneghini Fauth
3a7a0c6e58 Remove $url_query global from PHPStan ignored list
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 22:18:58 -03:00
Hugues Peccatte
b68ae133ca Add return type hint
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
d4699ac8a5 Remove unused private method
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
7b00f5d35a Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
ff3325870f Remove unused variables
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
91e9acb263 Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
59d720d7dd Remove useless method parameter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
158a13828f Remove useless unset
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
50bcfc8ed6 Remove useless attribute
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
e2f66cf9e4 Remove $text_dir global from PHPStan ignored errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-14 16:04:16 -03:00