gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,137 Commits 12 Branches 481 Tags 2.4 GiB
9188cf251b
Commit Graph

506 Commits

Author SHA1 Message Date
William Desportes
7d4eafd188
Fix #16851 - Default column order doesn't have have any effect ($cfg['Order']) since phpMyAdmin 4.2.0 
Introduced by a05ab9640b

See: a05ab9640b (diff-401fa9ac455f80ecd82d75155b189c586eadf55f976b2050915d031eaf79a39dL2022-L2040)

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-20 23:52:38 +01:00
William Desportes
b9c593c67d
Fix #17766 - Allow to open in a new tab copy and edit row actions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-25 19:55:53 +01:00
William Desportes
182cb205a7
Fix coding standard mistakes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 21:55:52 +01:00
William Desportes
45853b69b7
Fix #17902 - truncate "title" attribute of foreign keys 
BrowseForeigners::getDescriptionAndTitle() uses the same method

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 14:18:53 +01:00
iifawzi
5207fcdb68 phpcbf fixing trailing whitespaces 
Signed-off-by: iifawzi <iifawzie@gmail.com>
 2022-11-18 17:07:46 +02:00
iifawzi
b7bf83c24c Default to "Full texts" when running ANALYZE 
Signed-off-by: iifawzi <iifawzie@gmail.com>
 2022-11-18 17:00:10 +02:00
William Desportes
e97af7568e
Fix psalm baseline issues introduced by 8424e75907 
Ref: 8424e75907

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 15:15:25 +02:00
William Desportes
8424e75907
Fix "Link not found!" on foreign columns 
It also generated invalid queries with no column name to select.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-24 13:13:12 +02:00
Kamil Tekiela
dcdbcc019b
Fix method casing 
Ref: https://github.com/tecnickcom/TCPDF/pull/462

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-14 20:44:26 +02:00
Kamil Tekiela
c19f6ae9ce Fix isNumeric 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-10 15:02:15 +01:00
Maurício Meneghini Fauth
9f076774e5
Remove table-light CSS classes 
These classes were added by 6408b7179a.
However they aren't exactly the same as thead-light classes that exists
in Bootstrap 4.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/17455.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-14 17:31:31 -03:00
Maurício Meneghini Fauth
1c7aab1a4d
Fix issue reported by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-11 14:52:05 -03:00
Maurício Meneghini Fauth
a34dc9f064
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-08 14:14:52 -03:00
Maurício Meneghini Fauth
e2c4c4a10f
Replace for with foreach in Display\Results::getTable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-07 14:13:18 -03:00
Maurício Meneghini Fauth
973023737f
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-06 09:52:52 -03:00
Maurício Meneghini Fauth
29170a28f9
Remove UI props if cached fields count differs from actual 
- Fixes #17428
- Fixes #17498

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-05 22:33:58 -03:00
Maurício Meneghini Fauth
54df014550
Remove stickyfilljs JavaScript dependency 
This polyfill is not needed anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-27 19:47:31 -03:00
Lukas Bixen
78544d04d8 Fix navigation layout if row count unknown: 
Remove 'End' button and fix missing separator

Signed-off-by: Lukas Bixen <lrb2_@outlook.com>
 2022-02-07 20:46:44 -06:00
Maurício Meneghini Fauth
b59d46bc8d
Fix some Psalm errors after #17059 merge 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-07 13:44:53 -03:00
Philip Kroloq
8bd45c8ec0
fixed missing navigation buttons in view result tables 
Signed-off-by: Philip Kroloq <kroloq@web.de>
(cherry picked from commit 09aaa10b33)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-07 13:03:06 -03:00
William Desportes
65c9f49c1e
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-06 15:45:57 +01:00
Kamil Tekiela
b5a6729886
Fix #17239 - Repeating headers are not working 
Ref: 97810b3a21

igned-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-02-06 01:37:22 +01:00
William Desportes
c5dba46ca4
fix a coding standard unsolvable case 
Moving the return line did not help, so I removed it

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-04 18:42:33 +01:00
William Desportes
4bea65e29a
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-03 13:47:51 +01:00
William Desportes
3bd3ee074c
Fix #17315 - Unsupported operand types in Results.php 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-02-03 13:40:20 +01:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-11 14:31:56 -03:00
Maurício Meneghini Fauth
02e8588404
Merge branch 'QA_4_9-security' into QA_5_1-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-10 18:39:23 -03:00
Maurício Meneghini Fauth
0b575ff2e9
Fix URL encryption for Util::linkOrButton method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-10 12:19:44 -03:00
Kamil Tekiela
6e8a04c4ab Remove redundant condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
0cd422954b Remove redundant arguments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
75b5c3241c Remove optional $onclick parameter 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
cf16a3c55a Remove redundant parentheses 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
af4b8938b8 Collapse if statements into one 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
8e9dfe79db
Merge pull request #17243 from kamil-tekiela/Refactor-Results.php 
Refactor results.php
 2021-12-27 09:21:49 -03:00
Kamil Tekiela
e2dc2a9c86 Remove getUnsortedSqlAndSortByKeyDropDown() 
This was stupid abstraction. This method did 2 things. When the code that prepares unsorted SQL is moved out of this method, the rest can be absorbed by getSortByKeyDropDown(). This method didn't declare any local variables, it took parameters that were just passed along to other methods. The code to get unsorted SQL was just a single instruction that was self-explanatory. Indexes relied on properties so they didn't need to be a parameter to the other method.

This method only added complexity instead of reducing it.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
7a735ddf92 Redesign CSS class generation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
9969b9d103 $printview global is always null 
The variable is not set anywhere in the current codebase.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
acb91c0b34 Refactor Results.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
97810b3a21 Fix bug #17239 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
eba8621881 Use DI for Results.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c4e2582e56
Use TableName for RelationParameters tables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:57 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-22 11:43:45 -03:00
Maurício Meneghini Fauth
2a4b170a34
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-21 13:13:09 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Kamil Tekiela
903afe871b Bug fix: SQL string in confirmation popup should not be escaped 
The values of < > ' " & are double escaped in the confirmation dialog.
Since the values are inserted via twig into HTML, there is no need to
escape them twice.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-14 12:22:25 +00:00
Maurício Meneghini Fauth
4c3bf41d56
Use DatabaseName for RelationParameters::db instead of string 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
ce527035c2 PHPStan checkAlwaysTrueCheckTypeFunctionCall fixes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-08 15:26:52 +00:00