Commit Graph

1558 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
b0604623d8
Extract PageSettings dependency from controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-06 20:17:34 -03:00
Maurício Meneghini Fauth
95ae4f7612
Extract Config\PageSettings initialization from constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-06 16:37:40 -03:00
Maurício Meneghini Fauth
3abe8ed8d9
Improve Util::formatByteDown() return type hint
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 22:36:50 -03:00
Maurício Meneghini Fauth
1f935e57f7
Move the Import class to the Import namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 12:44:04 -03:00
Maurício Meneghini Fauth
f23ab54ca9
Move the Export class to the Export namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 12:28:38 -03:00
Sachin Bahukhandi
566a51ab18
Incorrect argument type fix (#18458)
* Incorrect argument type to variable

Signed-off-by: SachinBahukhandi <sachinb0013@gmail.com>

* Linted code

Signed-off-by: SachinBahukhandi <sachinb0013@gmail.com>

---------

Signed-off-by: SachinBahukhandi <sachinb0013@gmail.com>
2023-06-28 10:26:22 -03:00
ru-asdx
62a2b7fa34
Replace superglobals with serverrequest in ReplaceController (#18501)
* Replace superglobals with serverrequest in ReplaceController

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

* fixes

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

---------

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2023-06-26 14:48:40 -03:00
Maurício Meneghini Fauth
78e446e073
Merge pull request #18461 from kamil-tekiela/Globals-in-Manage
Globals in ManageController
2023-06-13 22:22:40 -03:00
Maurício Meneghini Fauth
de58d27326
Remove .pma-fieldset and related CSS classes
Replaces most of them with the Bootstrap card component.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-11 00:37:39 -03:00
Kamil Tekiela
079892b49e Add never return type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-06-07 21:35:05 +01:00
Maurício Meneghini Fauth
827d8de28f
Bump sql-parser version to 6.0.x-dev
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-07 15:49:07 -03:00
Maurício Meneghini Fauth
22c6a2f9d8
Add a wrapper around the exit language construct
Creates the PhpMyAdmin\ResponseRenderer::callExit() method as a wrapper
to the exit language construct. That makes the tests more correct as the
method will always stop the code execution.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-06 21:54:07 -03:00
Maurício Meneghini Fauth
9481236388
Merge pull request #18460 from kamil-tekiela/Globals-in-Status
Remove unused globals
2023-06-05 12:50:55 -03:00
Maurício Meneghini Fauth
1be42d13de
Create the Identifiers\Identifier interface
Changes Dbal\DatabaseName, Dbal\TableName and Triggers\TriggerName to
implements the new Identifier\Identifier interface.
Moves Dbal\DatabaseName, Dbal\TableName and Triggers\TriggerName to the
Identifiers namespace.
Renames the tryFromValue() and fromValue() methods to just tryFrom() and
from() respectively.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-01 19:09:25 -03:00
Maurício Meneghini Fauth
9c01b7ce48
Extract guard condition from Triggers\Triggers::export()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-31 02:37:38 -03:00
Maurício Meneghini Fauth
5c9847101c
Merge pull request #18453 from kamil-tekiela/quoteString
Use quoteString in CentralColumns
2023-05-30 14:28:19 -03:00
Maurício Meneghini Fauth
5ea9d2a2dc
Merge pull request #18459 from kamil-tekiela/Removal-of-GLOBALS
Removal of globals
2023-05-30 12:41:27 -03:00
Kamil Tekiela
3534027732 $GLOBALS['json']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 20:12:45 +01:00
Kamil Tekiela
84136fa2bb $GLOBALS['new_config']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 20:08:22 +01:00
Kamil Tekiela
9d931c878d $GLOBALS['return_url']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 20:06:05 +01:00
Kamil Tekiela
9e35b7b113 $GLOBALS['all_ok']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 20:01:57 +01:00
Kamil Tekiela
c948030634 $GLOBALS['form_display']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 20:00:31 +01:00
Kamil Tekiela
ce5d07a147 Remove unused globals
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 19:49:18 +01:00
Kamil Tekiela
6dae32cd7a $GLOBALS['warning_messages']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:54 +01:00
Kamil Tekiela
872410ea1b $GLOBALS['comment']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:54 +01:00
Kamil Tekiela
4141085204 $GLOBALS['notNull']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:54 +01:00
Kamil Tekiela
df1aef483e $GLOBALS['indexes']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:53 +01:00
Kamil Tekiela
9a13768bf9 $GLOBALS['hideOrderTable']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:53 +01:00
Kamil Tekiela
c215ed7baa $GLOBALS['columns']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:53 +01:00
Kamil Tekiela
d8e75913c8 $GLOBALS['new_tbl_storage_engine']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:51 +01:00
Kamil Tekiela
08454dcf2e $GLOBALS['table_alters']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:08:03 +01:00
Kamil Tekiela
b481240bb6 $GLOBALS['create_options']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:07:19 +01:00
Kamil Tekiela
dc28c432a1 $GLOBALS['row_format']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 13:06:10 +01:00
Kamil Tekiela
cab63eae59 $GLOBALS['show_comment']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 12:27:12 +01:00
Maurício Meneghini Fauth
5a344966a9
Move trigger row foreach loop into the list.twig template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 16:03:45 -03:00
Kamil Tekiela
42c3d84701 Assume that selected fields/tables are always string
Otherwise we would already be seeing plenty of errors when the values are used as string. Therefore this array must contain only strings.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-25 19:54:36 +01:00
Maurício Meneghini Fauth
81e988aac8
Inline Triggers::main() into the Triggers\IndexController
The main() method is handling the request/response, so it's better to
move this code to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 15:40:16 -03:00
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers
They are equivalent in current form.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
62ec1bcc2c
Merge pull request #18445 from kamil-tekiela/InsertEdit-pt4
InsertEdit refactoring - part 4
2023-05-24 21:16:01 -03:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2
Replace superglobals with serverrequest in GetFieldController
2023-05-24 15:31:24 -03:00
Kamil Tekiela
7838a42a34 Move buildInsertSqlQuery to Generator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-23 15:31:46 +01:00
Kamil Tekiela
1d180c5482 Use null as sentinel value in getColumn
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-19 16:33:01 +01:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-19 16:33:01 +01:00
Kamil Tekiela
3b611f3945 Implement ColumnFull DTO
This is MVP. In following commits the DTO will be expanded and improved.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-19 16:29:34 +01:00
Kamil Tekiela
231ec1ba8b Remove QBE
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-19 11:21:46 +01:00
Maurício Meneghini Fauth
2bf3cb587d
Merge pull request #18426 from kamil-tekiela/variableless-exceptions
Don't catch exception into variable
2023-05-18 20:45:12 -03:00
Kamil Tekiela
97da6c9721 Don't catch exception into variable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-12 23:09:51 +01:00
Kamil Tekiela
15a83c32af $db in addNewRelation()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-12 22:50:32 +01:00
Kamil Tekiela
4ec3b99ba3
Improve boolean conditions with arrays (#18417)
* Remove empty() on array

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove boolean count()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-12 15:16:26 -03:00
Maurício Meneghini Fauth
64b0fd54c7
Merge pull request #18397 from kamil-tekiela/Fix-18396
Fix #18396 - Export page always exports data
2023-05-12 13:51:28 -03:00