Commit Graph

93 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Feliks Toomsoo
d6dde0180d Fix the table chart by not escaping null values
Signed-off-by: Feliks Toomsoo <feliks.toomsoo@gmail.com>
2018-12-26 20:10:02 +02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
d7affca556 Fix uncaught TypeError in Util::printableBitValue
Fixes #14718

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 21:50:42 -02:00
Maurício Meneghini Fauth
6fd9bfb75b Retrieve parameters from $_POST in table search
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d1d90b59b2 Retrieve parameters from $_POST in table relation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d01ece698a Retrieve parameters from $_POST in tbl_indexes.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
9219b28f47 Retrieve parameters from $_POST in table structure
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
Alessandro Dolci
fd3dde47a6 Fixed condition on the emptiness of enum type criteriaValues array (#14648)
The if condition has a call to the empty function on the criteriaValues array, but in the considered case that array only contains a '0', so this makes it look empty to the function. I added a control on the first element of the array, to avoid this specific situation.
It's my first contribution, so I hope I did well with the branches. Let me know if there's something missing or to do, I'm happy to help.

Signed-off-by: Alessandro Dolci <alessandro.dolci@pm.me>
(cherry picked from commit 3f5fff3f4d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-30 21:09:02 -03:00
Alessandro Dolci
3f5fff3f4d Fixed condition on the emptiness of enum type criteriaValues array (#14648)
The if condition has a call to the empty function on the criteriaValues array, but in the considered case that array only contains a '0', so this makes it look empty to the function. I added a control on the first element of the array, to avoid this specific situation.
It's my first contribution, so I hope I did well with the branches. Let me know if there's something missing or to do, I'm happy to help.

Signed-off-by: Alessandro Dolci <alessandro.dolci@pm.me>
2018-10-30 21:05:33 -03:00
Lakshay arora
2a07cee164 Automatically add index while editing an existing row and setting auto increment (#14417)
* Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
* Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-10-23 16:33:36 -03:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
Maurício Meneghini Fauth
5455897555 Fix unescaped string in table structure view
https://github.com/phpmyadmin/phpmyadmin/issues/14374#issuecomment-410017440

Introduced by commit 5d0fd81e67

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-28 02:41:27 -03:00
Maurício Meneghini Fauth
0913246f63
Merge pull request #14559 from CommanderRoot/patch-1
Fix displaying of indexes
2018-08-24 22:44:36 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
CommanderRoot
2f8502825c
Fix displaying of indexes
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2018-08-09 16:22:59 +02:00
Leonardo Strozzi
fc9ccff218 Remove get_div_for_slider_effect twig extension
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-08-08 22:15:00 -03:00
Leonardo Strozzi
76ad22cb8a Remove partition Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-08-03 17:00:30 -03:00
Leonardo Strozzi
aee045f960 Remove index Twig extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-08-03 17:00:30 -03:00
laps15
669b8a512d Refactor table relation's templates (#14490)
* Fix secondary tabs bug
* Refactor table relation's templates
* Fix phpstan error report mentioned on pr #14483

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-07-27 18:16:52 -03:00
Isaac Bennetch
c59483b277 Correct missing space typo from commit 037bbbdbc3
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-07-20 09:52:23 -04:00
Isaac Bennetch
037bbbdbc3 Fix multiple Uncaught TypeError messages when editing a table's partitions.
Closes #14494

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-07-20 09:50:17 -04:00
Leonardo Strozzi
6b08a7c326 Refactor table secondary tabs tamplate
Implements inheritance on relation and structure templates

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-07-13 09:43:41 -03:00
Lakshay arora
39f19fd20f Fix NULL as default not shown, #14333
Signed-Off-By: Lakshay arora<arora.lakshya123@gmail.com>
2018-06-20 15:09:07 +05:30
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
William Desportes
5815c1570e
Closes #14225 - missing index icon
Closes: #14225
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-12 20:38:29 +02:00
William Desportes
bdb52e808a
Closes #14374 - Structure broken
Security issue fix.

Closes: #14374
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-12 20:37:49 +02:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
93bf3d0d17
Merge pull request #14341 from laps15/bugfix
Fix bug reported on pull request #14305
2018-05-29 21:30:22 -06:00
Leonardo Strozzi
5d0fd81e67 Remove Twig php function extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 23:06:31 -03:00
Leonardo Strozzi
c021125052 Fix bug reported on pull request #14305
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 22:27:48 -03:00
Maurício Meneghini Fauth
2d5825d73e
Merge pull request #14305 from laps15/refactor
Remove md5 twig extension
2018-05-22 23:01:52 -03:00
Maurício Meneghini Fauth
dce862d41b Remove dbi global from Controllers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-22 16:51:03 -03:00
Leonardo Strozzi
927fed774c Remove md5 twig extension
Adapt templates to remove md5 from PhpFuncionsExtension.php

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-22 07:54:03 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
5f46a4ba52 Enable strict mode in Controllers classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:18:52 -03:00
Lakshay arora
0da5857b5d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 03:54:28 -03:00
Lakshay arora
9231620c2d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-05-12 03:44:58 -03:00
Maurício Meneghini Fauth
dc72341b75 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:44:19 -03:00
Maurício Meneghini Fauth
de250fbae3 Fix MariaDB 10.2 current_timestamp()
Fixes #13968 and fixes #13999. Closes #14177.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:39:53 -03:00
Madhura Jayaratne
bb9fc5d6e9 Merge branch 'QA_4_8' 2018-05-06 09:00:52 +10:00