Commit Graph

118706 Commits

Author SHA1 Message Date
William Desportes
a1a6dd99ea
Move vPath, aPath, pos to paths_nav using data-* attributes
Ref: d944f0851e
Ref: aec59d5007

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 00:58:16 +02:00
William Desportes
aec59d5007
Move pos3_name and pos3_value to pos3_nav using data-* attributes
Ref: d944f0851e

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 00:47:11 +02:00
William Desportes
d944f0851e
Move pos2_name and pos2_value to pos2_nav using data-* attributes
Note: data-* are standard attributes

I did not move the back-end part so it is easier to find the places to refactor calls

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 00:41:32 +02:00
William Desportes
928549a71b
Merge #16148 - Fix #16147 - php error after DBI code extraction
Fixes: #16147
Pull-request: #16148

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-30 22:38:43 +02:00
Maurício Meneghini Fauth
2937e9796d Remove underscore prefix from some method names
Related to #16149

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 17:20:43 -03:00
Maurício Meneghini Fauth
e29f892d62 Use consts to select the CodeGen handler format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:36:32 -03:00
Maurício Meneghini Fauth
e6b23cf9ef Fix TypeError in Util::getDbInfo
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
Maurício Meneghini Fauth
e2eac49ad2 Use closures to call private methods as callback
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
CommanderRoot
5a1c5acccc
Fix #16147
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-05-30 03:26:45 +02:00
Petr Duda
0271fcbbe8
Translated using Weblate (Czech)
Currently translated at 95.8% (3215 of 3355 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/cs/
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-29 22:41:37 +02:00
William Desportes
889715fefa
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-28 09:46:33 +02:00
William Desportes
1d1f01891c
Access random id from Abstract GisGeometry
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-28 09:42:46 +02:00
William Desportes
81be9a3a31
Add a ChangeLog entry for 43564f5f5f
Ref: 43564f5f5f

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-28 09:40:57 +02:00
William Desportes
43564f5f5f
Fix twig deprecations for php 8
Ref: https://github.com/twigphp/Twig/issues/3327
Upstream: https://github.com/twigphp/Twig/pull/3331

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-28 09:39:30 +02:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
199e3d9813 Fix coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:08:55 -03:00
Maurício Meneghini Fauth
2c5f80fc46 Upgrade phpmyadmin/coding-standard to v2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 20:32:00 -03:00
William Desportes
b341a58947
Add tests for Util::{testGetConditionValue, testListPHPExtensions}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 21:51:14 +02:00
William Desportes
aff8b646aa
Extract Util::getConditionValue from Util:getUniqueCondition
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 21:48:42 +02:00
William Desportes
1dd98ba696
Trim down Relation::checkTableAccess
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 21:03:44 +02:00
William Desportes
c86f90dffa
Split some code in Relation class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 19:20:53 +02:00
William Desportes
aba5e27a82
Some code fixes and improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:55:58 +02:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:18:01 +02:00
William Desportes
e184b470cd
Fix testDuplicateInfo after last commit, it does return -1
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:15:18 +02:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Olivier Humbert
ee9630b4cb
Translated using Weblate (French)
Currently translated at 100.0% (3334 of 3334 strings)

[CI skip]

Translation: phpMyAdmin/5.0
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/fr/
Signed-off-by: Olivier Humbert <trebmuh@tuxfamily.org>
2020-05-26 09:41:40 +02:00
Olivier Humbert
c46ab68833
Translated using Weblate (French)
Currently translated at 100.0% (3355 of 3355 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/fr/
Signed-off-by: Olivier Humbert <trebmuh@tuxfamily.org>
2020-05-26 09:41:36 +02:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
91bf091350 Fix issue with mysql bit conversion in InsertEditTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 23:42:08 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
d82eb1b24a
Mark extensions to skip tests on minimal php setups
This will help people packaging phpMyAdmin and also make our test suite runnable by more people.

Tested on alpine with the minimal extensions:
php-dom php-iconv php-mysqli php-json php-mbstring php-iconv php-session

[PHP Modules]
Core
date
dom
filter
hash
iconv
json
libxml
mbstring
mysqli
mysqlnd
openssl
pcre
readline
Reflection
session
SPL
standard
zlib



Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-25 23:20:53 +02:00
William Desportes
1affd8e634
Remove language specific config for selenium tests after 325357c121
Ref: 325357c121
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-25 23:20:53 +02:00
Maurício Meneghini Fauth
dfc53f3def Remove inline HTML
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 18:16:48 -03:00
Petr Duda
d5a4040ffe
Translated using Weblate (Czech)
Currently translated at 97.6% (3256 of 3334 strings)

[CI skip]

Translation: phpMyAdmin/5.0
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/cs/
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-24 22:41:39 +02:00
Maurício Meneghini Fauth
0b9c35a056 Remove uses statements from the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-24 13:00:24 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 15:25:56 +02:00
William Desportes
0a6a316b2a
Improve TravisCI config for selenium step and add TESTSUITE_SERVER env
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 15:07:25 +02:00
William Desportes
b12587b8e4
Add TESTSUITE_DATABASE ENV
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 14:34:36 +02:00
William Desportes
cf6c3be29a
Fix DROP DATABASE queries
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 14:34:05 +02:00
William Desportes
458100f16a
Fix OperationsTest::testCopyTable
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 14:04:00 +02:00
William Desportes
b593fd334f
Some selenium code improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 13:52:29 +02:00
William Desportes
b49745ceef
Remove all globals for selenium tests and use getenv
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 13:51:50 +02:00
William Desportes
325357c121
Select English if the selector exists on selenium tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 13:26:14 +02:00