Kamil Tekiela
a67dd95705
Set return types in OptionsPropertyOneItem
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 23:50:59 +00:00
Kamil Tekiela
b224b7f0e0
Set native types in OptionsPropertyItem
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 23:50:59 +00:00
Kamil Tekiela
235b4701bc
Set native types in PropertyItem
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 23:50:59 +00:00
Kamil Tekiela
771402e99e
Make $doc strictly typed
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 23:50:59 +00:00
Kamil Tekiela
e27394f9b6
Set $len to default 0
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 23:50:59 +00:00
Kamil Tekiela
04b6967174
Set $size to default 0
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 23:50:59 +00:00
Kamil Tekiela
b48c445120
Deimplement incompatible method
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 23:50:58 +00:00
Maurício Meneghini Fauth
db267cfb27
Merge pull request #18137 from kamil-tekiela/quoteString-control-user
...
Add Connection::TYPE_CONTROL to quoteString
2023-02-21 20:38:33 -03:00
Maurício Meneghini Fauth
cb67fa306d
Remove Reflection's setAccessible() method
...
This method is no-op since PHP 8.1.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 20:35:45 -03:00
Maurício Meneghini Fauth
f2bdca0439
Refactor some Command tests to remove withConsecutive method
...
The PHPUnit's InvocationMocker::withConsecutive() has been deprecated.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 19:52:17 -03:00
Kamil Tekiela
912f179432
Add Connection::TYPE_CONTROL to quoteString
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 22:36:01 +00:00
Maurício Meneghini Fauth
d5b068b8e3
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 19:32:32 -03:00
Maurício Meneghini Fauth
07af9572ea
Use constructor prop promotion for RelationParameters class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 18:51:25 -03:00
Maurício Meneghini Fauth
1ffd881fb4
Refactor ConfigStorage\RelationCleanup::user()
...
- Replaces escapeString() with quoteString()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 18:22:39 -03:00
Maurício Meneghini Fauth
b4f9063ceb
Refactor ConfigStorage\RelationCleanup::database()
...
- Replaces escapeString() with quoteString()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 17:54:20 -03:00
Maurício Meneghini Fauth
bddaa399af
Refactor ConfigStorage\RelationCleanup::table()
...
- Replaces escapeString() with quoteString()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 17:19:10 -03:00
Maurício Meneghini Fauth
c4a5440cf0
Refactor ConfigStorage\RelationCleanup::column()
...
- Replaces escapeString() with quoteString()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 15:51:24 -03:00
William Desportes
06733a8733
Translated using Weblate (Italian)
...
Currently translated at 99.7% (3428 of 3438 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/it/
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-21 19:08:28 +01:00
Maurício Meneghini Fauth
e7a5cc897a
Refactor Server\PrivilegesTest to remove withConsecutive method
...
The PHPUnit's InvocationMocker::withConsecutive() has been deprecated.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 14:56:25 -03:00
Maurício Meneghini Fauth
0ba371f921
Refactor ConfigStorage\UserGroups::delete()
...
- Extracts dbi global variable
- Replaces escapeString with quoteString
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 14:40:25 -03:00
Maurício Meneghini Fauth
19762dbf75
Refactor TrackerTest to remove withConsecutive method
...
The PHPUnit's InvocationMocker::withConsecutive() has been deprecated.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 14:09:05 -03:00
Maurício Meneghini Fauth
2722ea717d
Replace escapeString with quoteString in AccountLocking class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 13:43:14 -03:00
Maurício Meneghini Fauth
5cf1ec8bc3
Refactor UtilTest to remove withConsecutive method
...
The PHPUnit's InvocationMocker::withConsecutive() has been deprecated.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 13:22:30 -03:00
Maurício Meneghini Fauth
193862ca92
Merge pull request #18135 from kamil-tekiela/Remove-generateRowQueryOutput
...
Remove generateRowQueryOutput() method
2023-02-21 12:03:48 -03:00
Kamil Tekiela
54e4ec68fd
Stop using PHP_EOL ( #18101 )
...
* s/PHP_EOL/"\n"
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* PHP_EOL seems to have been intentional here
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Merge concats together
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 11:58:56 -03:00
Maurício Meneghini Fauth
1210a256a2
Update PHPStan/Psalm baselines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 11:48:15 -03:00
Kamil Tekiela
f874bf1d99
Remove generateRowQueryOutput() method
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-21 14:45:59 +00:00
Maurício Meneghini Fauth
47846068fa
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 23:45:06 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type
...
Since union type are now possible, using union with null makes more
clear that it is a union type.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
8eb1cef07d
Use generic template for ExportRelationSchema::$diagram
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:18:39 -03:00
Maurício Meneghini Fauth
772648a97b
Use DatabaseName object for ExportRelationSchema::$db
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 20:30:29 -03:00
William Desportes
a174a41f5d
Add a ChangeLog entry for #16851
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:54:34 +01:00
William Desportes
9743c82ba3
Write tests for #16851
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:52:40 +01:00
William Desportes
7d4eafd188
Fix #16851 - Default column order doesn't have have any effect ($cfg['Order']) since phpMyAdmin 4.2.0
...
Introduced by a05ab9640b
See: a05ab9640b (diff-401fa9ac455f80ecd82d75155b189c586eadf55f976b2050915d031eaf79a39dL2022-L2040)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:52:38 +01:00
William Desportes
f3bd71d937
Fix a coding-standard issue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:52:37 +01:00
William Desportes
4ce69f3a3d
Nicely exit in case of an early PHP type crash
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-02-20 23:51:21 +01:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
48f671d956
Replace get_class() with ::class constant
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:58:13 -03:00
Maurício Meneghini Fauth
efed55320d
Fix invalid PHP doc blocks
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:46:35 -03:00
Maurício Meneghini Fauth
bd095c7bb4
Merge pull request #18132 from kamil-tekiela/fix-after-merge
...
Fix merge issues
2023-02-20 18:24:18 -03:00
Maurício Meneghini Fauth
b0bc4f460e
Use null safe object operator where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:21:56 -03:00
Maurício Meneghini Fauth
82693daebc
Improve type declaration of SavedSearches::$criterias
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:12:19 -03:00
Maurício Meneghini Fauth
5aeaca0a9a
Remove unnecessary global vars from QBE controller
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 17:51:18 -03:00
Kamil Tekiela
c311b9fdcb
Fix merge issues
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-20 20:43:12 +00:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 17:03:05 -03:00
Maurício Meneghini Fauth
5cbb878dda
Replace Heredoc strings with Nowdoc strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 16:46:21 -03:00
Maurício Meneghini Fauth
4b71da0566
Merge pull request #18127 from kamil-tekiela/nonUnique-to-bool
...
Change nonUnique prop to be bool
2023-02-20 16:32:44 -03:00
Maurício Meneghini Fauth
2a4803a81b
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 15:18:28 -03:00
Maurício Meneghini Fauth
6b35829406
Add ChangeLog entries for #18106 and #18120
...
- https://github.com/phpmyadmin/phpmyadmin/pull/18120
- https://github.com/phpmyadmin/phpmyadmin/pull/18106
- https://github.com/phpmyadmin/phpmyadmin/issues/18105
[ci skip]
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 13:50:54 -03:00
Maurício Meneghini Fauth
6eb4b4d5ad
Merge pull request #18120 from kamil-tekiela/bug-with-numerical-table-names-during-rename
...
Fix bug with numerical tables during renaming DB
2023-02-20 13:43:51 -03:00