gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

555 Commits

Author SHA1 Message Date
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Maurício Meneghini Fauth
d5b068b8e3
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-21 19:32:32 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
William Desportes
7d4eafd188
Fix #16851 - Default column order doesn't have have any effect ($cfg['Order']) since phpMyAdmin 4.2.0 
Introduced by a05ab9640b

See: a05ab9640b (diff-401fa9ac455f80ecd82d75155b189c586eadf55f976b2050915d031eaf79a39dL2022-L2040)

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-20 23:52:38 +01:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-19 23:19:54 +00:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
0819043d0e
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-08 14:09:59 -03:00
Kamil Tekiela
e3e351c676 Remove dead code 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-25 00:59:43 +00:00
Kamil Tekiela
6264f6f1ea
Various refactorings 2 (#17965) 
* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-24 12:54:23 -03:00
William Desportes
b9c593c67d
Fix #17766 - Allow to open in a new tab copy and edit row actions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-25 19:55:53 +01:00
Maurício Meneghini Fauth
d2809ca096
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-21 13:50:30 -03:00
William Desportes
182cb205a7
Fix coding standard mistakes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 21:55:52 +01:00
William Desportes
1df41153e4
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 15:12:54 +01:00
William Desportes
45853b69b7
Fix #17902 - truncate "title" attribute of foreign keys 
BrowseForeigners::getDescriptionAndTitle() uses the same method

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 14:18:53 +01:00
William Desportes
b820730f84
Fix PR #17906 on master branch 
Pull-request: #17906

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:31:41 +01:00
William Desportes
a60437f04a
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:09:44 +01:00
iifawzi
5207fcdb68 phpcbf fixing trailing whitespaces 
Signed-off-by: iifawzi <iifawzie@gmail.com>
 2022-11-18 17:07:46 +02:00
iifawzi
b7bf83c24c Default to "Full texts" when running ANALYZE 
Signed-off-by: iifawzi <iifawzie@gmail.com>
 2022-11-18 17:00:10 +02:00
Maurício Meneghini Fauth
6647365c78
Refactor Display\Results::getOffsets() method 
Improves type inference.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 15:19:01 -03:00
aliber4079
c958e27bfa
fix #17779 - PHP 8 numeric operation (#17827) 
Fixes #17779

php8 throws exception in spite of @ symbol so work around it

Signed-off-by: Alex Liberman <alex@zoosmart.us>
 2022-11-05 14:46:58 -03:00
William Desportes
ea5a541f7b
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 17:26:44 +02:00
William Desportes
e97af7568e
Fix psalm baseline issues introduced by 8424e75907 
Ref: 8424e75907

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 15:15:25 +02:00
William Desportes
25c13d667b
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-26 12:22:38 +02:00
William Desportes
8424e75907
Fix "Link not found!" on foreign columns 
It also generated invalid queries with no column name to select.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-24 13:13:12 +02:00
Maurício Meneghini Fauth
b054d0091e
Merge pull request #17807 from kamil-tekiela/table-dbi 
Pass $dbi as argument to Table
 2022-10-18 11:08:36 -03:00
Maurício Meneghini Fauth
c76bb77b3c
Merge pull request #17805 from kamil-tekiela/Fix-phpstan-issues3 
Fix static analysis issues
 2022-10-18 11:05:32 -03:00
Maurício Meneghini Fauth
0f57dfff5b
Merge pull request #17800 from kamil-tekiela/Fix-phpstan-issues-2 
Fix PHPStan issues 2
 2022-10-17 20:32:59 -03:00
Kamil Tekiela
2c416128e5 Pass as argument to Table 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 22:30:33 +01:00
Kamil Tekiela
2d3c4bf749 Minor code simplifications 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 14:43:28 +01:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 17:18:54 -03:00
Kamil Tekiela
7b6149ba0e RedundantCastGivenDocblockType 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-15 21:16:04 +01:00
Kamil Tekiela
0ca6b456d5 Casting to int something that's already int 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-15 20:15:50 +01:00
William Desportes
007915bc0a
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-14 20:49:18 +02:00
Kamil Tekiela
dcdbcc019b
Fix method casing 
Ref: https://github.com/tecnickcom/TCPDF/pull/462

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-14 20:44:26 +02:00
Maurício Meneghini Fauth
059705f06e
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-11 19:53:54 -03:00
Kamil Tekiela
c19f6ae9ce Fix isNumeric 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-10 15:02:15 +01:00
Maurício Meneghini Fauth
9d2350d28c
Extract dbi global variable from Index::loadIndexes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-07 21:59:03 -03:00
Maurício Meneghini Fauth
10b937511d
Replace $analyzedSqlResults array with StatementInfo object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-24 21:35:30 -03:00
Maurício Meneghini Fauth
4d7cb34a68
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-15 17:27:03 -03:00
Maurício Meneghini Fauth
9f076774e5
Remove table-light CSS classes 
These classes were added by 6408b7179a.
However they aren't exactly the same as thead-light classes that exists
in Bootstrap 4.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/17455.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-14 17:31:31 -03:00
Maurício Meneghini Fauth
4750e0f234
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-11 15:07:07 -03:00
Maurício Meneghini Fauth
1c7aab1a4d
Fix issue reported by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-11 14:52:05 -03:00
Maurício Meneghini Fauth
7aa512c357
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-08 14:15:49 -03:00
Maurício Meneghini Fauth
a34dc9f064
Merge branch 'QA_5_1' into QA_5_2 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-08 14:14:52 -03:00