Commit Graph

117826 Commits

Author SHA1 Message Date
William Desportes
b97a2edcfa
#16007 - Improve service loader null checks
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-06 23:14:31 +01:00
William Desportes
18b7622b6f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-06 08:27:45 +01:00
William Desportes
a6e0d7f453
Add ChangeLog entry for pull-request #16015 (fa7e63328b)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-06 08:26:58 +01:00
William Desportes
fa7e63328b
Merge #16015 - Fix error in NavigationTree where $key might be sent as an int instead of a str to urlencode
Pull-request: #16015

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-06 08:24:41 +01:00
Simon Vikstrom
e472b8bbc4
Fix "Uncaught TypeError: urlencode() expects parameter 1 to be string, int given in"
If a user creates two tables prefixed with number__... like
2020__abc
2020__cde

then phpmyadmin will group then, the key will end up being an integer instead of a string and  PHP will error out on it.

Signed-off-by: Simon Vikstrom <pullreq@devsn.se>
2020-03-06 08:18:11 +01:00
William Desportes
c631bb66e2
Fix #16014 - Undefined indexes in services_loader.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-06 08:11:04 +01:00
William Desportes
9a5b4d3aba
#16007 - Improve service loader
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-06 08:06:18 +01:00
William Desportes
30990a1d24
Fix EnvironmentTest path in phpunit.xml*
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 21:28:01 +01:00
William Desportes
cf0e0867b1
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 21:19:57 +01:00
William Desportes
ce85e5ee13
Remove json logging for nocoverage phpunit xml file and remove useless file
Ref: 3b3fbaefdb

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 21:18:09 +01:00
William Desportes
0f0b10cba6
Add ChangeLog entry for 40945551f0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 21:15:11 +01:00
William Desportes
40945551f0
Support phpunit 9.0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 21:13:12 +01:00
William Desportes
3b3fbaefdb
Remove json logging removed in phpunit 6.0 (version that we no longer support)
Ref: https://github.com/sebastianbergmann/phpunit/blob/6.0.0/ChangeLog-6.0.md#removed
"Removed the --log-json commandline option (deprecated in PHPUnit 5.7)"

This commit is done for phpunit 9.0 to not complain about it

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 21:12:35 +01:00
William Desportes
a3d9ca40f7
Add ChangeLog entries for #16005
Yes, I added 2 entries. I want to make it obvious that we removed a dependency.
Packaging folks ;)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 20:57:08 +01:00
William Desportes
c9916c224e
Merge #16007 - Improve performance of dependency injection system by removing yaml parsing
Pull-request: #15678
Ref: #16005

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 20:48:42 +01:00
William Desportes
07e4fbc055
Reduce nesting in services loader function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 20:22:50 +01:00
William Desportes
0ab8d35af3
Ref #16005 - Transform plain strings to ::class names
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 20:22:15 +01:00
William Desportes
9977c8c7ea
Update ChangeLog entry for #16009
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-05 20:01:56 +01:00
yagoub fadel
ba512491c1
Translated using Weblate (Arabic)
Currently translated at 48.0% (1601 of 3332 strings)

[CI skip]

Translation: phpMyAdmin/5.0
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/ar/
Signed-off-by: yagoub fadel <yagoub76@gmail.com>
2020-03-05 06:32:58 +01:00
yagoub fadel
98afcce22b
Translated using Weblate (Arabic)
Currently translated at 47.7% (1594 of 3335 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ar/
Signed-off-by: yagoub fadel <yagoub76@gmail.com>
2020-03-05 06:32:57 +01:00
Maurรญcio Meneghini Fauth
6d4253b3d1 Set package as private in package.json
Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-04 14:47:15 -03:00
William Desportes
ae182cddb5
Ref #16005 - Move services loader to a php array
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-04 08:44:12 +01:00
William Desportes
cea02fff34
Remove symfony/yaml dependency
Ref: 380707fbcd

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-04 08:36:09 +01:00
Maurรญcio Meneghini Fauth
06c9db3929 Extract HTML from mult_submits replace prefix
Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-03 12:44:41 -03:00
yagoub fadel
741f230051
Translated using Weblate (Arabic)
Currently translated at 47.5% (1583 of 3332 strings)

[CI skip]

Translation: phpMyAdmin/5.0
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/ar/
Signed-off-by: yagoub fadel <yagoub76@gmail.com>
2020-03-03 09:32:55 +01:00
Maurรญcio Meneghini Fauth
1395cdc1d0 Extract HTML from MultSubmits::getHtmlForCopyMultipleTables
Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 22:01:16 -03:00
Maurรญcio Meneghini Fauth
a916c75547 Use early exit when possible in DbTableExists class
Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 18:39:46 -03:00
Maurรญcio Meneghini Fauth
b75aa9ca49 Extract checkDatabase and checkTable private methods
Extracts from PhpMyAdmin\DbTableExists::check().

Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 18:39:46 -03:00
Maurรญcio Meneghini Fauth
82db7444c3 Extract db_table_exists.inc.php to DbTableExists class
Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 17:01:26 -03:00
Maurรญcio Meneghini Fauth
b564c2f1db Fix navigation bg transparency with Bootstrap theme
Fixes #15985

Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 13:58:50 -03:00
Maurรญcio Meneghini Fauth
7bc67a2024 Upgrade PHPStan to v0.12
Signed-off-by: Maurรญcio Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 12:55:51 -03:00
Michal Biesiada
5c414acb17
Translated using Weblate (Polish)
Currently translated at 95.9% (3201 of 3335 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/pl/
Signed-off-by: Michal Biesiada <blade-14@o2.pl>
2020-03-02 00:32:50 +01:00
William Desportes
3a7e20b825
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-29 00:30:35 +01:00
William Desportes
10ca692ea3
Merge #16000 - Improve selenium tests stability
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-28 23:18:51 +01:00
William Desportes
4c5fe772b9
Mark tests as passed on BrowserStack
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 23:52:39 +01:00
William Desportes
0d3e6c1603
Fix phpdoc block
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 23:19:48 +01:00
William Desportes
26d315b5e5
Find an alternative to make scrolling work on testDropTable
Ref: https://github.com/php-webdriver/php-webdriver/issues/773
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:08 +01:00
William Desportes
5e43765058
Add access to console logs from chromedriver
Add logging for chrome driver https://stackoverflow.com/a/53305034/5155484

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:08 +01:00
William Desportes
e92badc3a6
Fix/improve CreateDropDatabaseTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:07 +01:00
William Desportes
3e6326a4be
Stop webdriver session when the test failed
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:07 +01:00
William Desportes
29306ee18b
Add scrollToElement function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:06 +01:00
William Desportes
bc8216e903
Fix selenium tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:05 +01:00
William Desportes
af7fe33b0a
Add ChangeLog entry for #15663
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-25 22:34:53 +01:00
William Desportes
3a765576c5
Merge #15678 - Fix #15663 show structure after adding a column
Pull-request: #15678
Fixes: #15663

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-25 22:33:55 +01:00
William Desportes
edb48b8d01
Add ChangeLog entry for #15662
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-25 22:29:07 +01:00
William Desportes
b5ecd65e13
Merge #15675 - Fix #15662 stay on the structure page when editing indexes
Pull-request: #15675
Fixes: #15662

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-25 22:27:31 +01:00
William Desportes
4a30500145
Add ChangeLog entry for #15582
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-25 22:14:16 +01:00
William Desportes
4cea049ddf
Merge #15585 - Fix #15582 Don't disable "Empty"-button after clicking
Pull-request: #15585
Fixes: #15582

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-25 22:08:02 +01:00
Hugues Peccatte
cbdd6d6cc5 Fix #15582 Don't disable "Empty"-button after clicking
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2020-02-25 21:53:40 +01:00
William Desportes
9e981f2f30
Add ChangeLog entry for #12969 and fix typo on previous entry
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 15:35:52 +01:00