Commit Graph

91 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
William Desportes
5815c1570e
Closes #14225 - missing index icon
Closes: #14225
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-12 20:38:29 +02:00
William Desportes
bdb52e808a
Closes #14374 - Structure broken
Security issue fix.

Closes: #14374
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-12 20:37:49 +02:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
93bf3d0d17
Merge pull request #14341 from laps15/bugfix
Fix bug reported on pull request #14305
2018-05-29 21:30:22 -06:00
Leonardo Strozzi
5d0fd81e67 Remove Twig php function extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 23:06:31 -03:00
Leonardo Strozzi
c021125052 Fix bug reported on pull request #14305
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 22:27:48 -03:00
Maurício Meneghini Fauth
2d5825d73e
Merge pull request #14305 from laps15/refactor
Remove md5 twig extension
2018-05-22 23:01:52 -03:00
Maurício Meneghini Fauth
dce862d41b Remove dbi global from Controllers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-22 16:51:03 -03:00
Leonardo Strozzi
927fed774c Remove md5 twig extension
Adapt templates to remove md5 from PhpFuncionsExtension.php

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-22 07:54:03 -03:00
Maurício Meneghini Fauth
1c2a2bb768 Fix TypeError in ServerDatabasesController
Fixes #14304

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-19 14:36:49 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
5f46a4ba52 Enable strict mode in Controllers classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:18:52 -03:00
Lakshay arora
9231620c2d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-05-12 03:44:58 -03:00
Maurício Meneghini Fauth
dc72341b75 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:44:19 -03:00
Maurício Meneghini Fauth
de250fbae3 Fix MariaDB 10.2 current_timestamp()
Fixes #13968 and fixes #13999. Closes #14177.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:39:53 -03:00
Madhura Jayaratne
bb9fc5d6e9 Merge branch 'QA_4_8' 2018-05-06 09:00:52 +10:00
Madhura Jayaratne
7b27484897 Fix #14239 Line and some other charts ignore result set order of values chosen for the x-axis
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-05-06 08:59:06 +10:00
Piyush Vijay
efaf47050a
Move columns preview SQL: #14155 feature added
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-04-22 02:38:45 +05:30
Maurício Meneghini Fauth
d758e062a9 Refactor PhpMyAdmin\Replication methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-13 18:21:55 -03:00
Maurício Meneghini Fauth
c73e72e7ca Refactor PhpMyAdmin\Transformations static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-01 01:34:17 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Xinyu Liu
7391d872a9 Fix improperly escaped HTML code in database structure page #14071
Signed-off-by: Xinyu Liu <meteor.lxy@foxmail.com>
2018-03-19 08:06:33 +00:00
Maurício Meneghini Fauth
741a50a905 Merge branch 'QA_4_7' 2018-03-12 19:24:44 -03:00
Maurício Meneghini Fauth
0889b52c36 Replace static methods with instance methods
Replace PhpMyAdmin\Sql static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-27 17:39:16 -03:00
Maurício Meneghini Fauth
79ab4f4a50 Use DI for DatabaseInterface instance
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-15 15:04:37 -02:00
Maurício Meneghini Fauth
dc04987a68 Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-15 12:31:04 -02:00
Maurício Meneghini Fauth
4c661bd1fd Move current server user global to constructor
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
e2a648881c Move DatabaseInterface object to constructor
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
dc2b2d4f6c Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
39198725fe Use CSS to hide table structure action buttons
Fix #13694

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-31 18:25:21 -02:00
Michal Čihař
c162a75b9b Improve javascript loading
- jquery-ui-timepicker-addon.js is loaded in Header, no need to load it
  elsewhere
- jquery.validate.js is needed on way to many pages to benefit of
  loading only on some of them

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 08:36:23 +01:00
Michal Čihař
77f0d50bea Add missing dependency on jquery.validate.js
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 15:09:43 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Michal Čihař
868bb18c98 Better deal with unitialized page
Fixes #13814

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 16:39:28 +01:00
Maurício Meneghini Fauth
cc2c4fc36d Replace globals with DI in Charsets class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-09 11:31:42 -02:00
Maurício Meneghini Fauth
5a70c1d895 Replace globals with DI in CentralColumns class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-05 22:21:58 -02:00
Maurício Meneghini Fauth
e631affbf3 Remove unnecessary include_once
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-04 16:10:22 -02:00
Maurício Meneghini Fauth
452b624dc4 Move dependencies to outside of abstract controllers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-04 12:41:57 -02:00
Maurício Meneghini Fauth
2ae2b8b54e Use template for server databases table
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-03 11:31:01 -02:00
Maurício Meneghini Fauth
ff38d5c5eb Move sub page header to index template
Move server/sub_page_header template from ServerDatabasesController
to server/databases/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
79f6f88bff Use template for server sub page header
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
6672d4f2ea Use template for server databases index
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
569ee91f2a Merge branch 'master' into templates
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-01 12:06:09 -02:00
Michal Čihař
f859a9701d Rewrite selection of tables with overhead
Avoid using inline generated javascript, use CSS selectors instead.

Issue #12782

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-30 12:19:38 +01:00
Maurício Meneghini Fauth
9b653cbba3 Port table/relation/common_form template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-29 16:46:52 -02:00
Maurício Meneghini Fauth
d4464f948c Port server/databases/table_row template to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-29 12:18:28 -02:00