Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
William Desportes
d82e85f852
Merge branch 'QA_5_1'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-23 18:46:05 +02:00
William Desportes
7e90190ee8
Fix second export refresh button not working
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-23 16:40:58 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
Maurício Meneghini Fauth
e31dd6d49d
Remove dump_buffer globals
...
Replaces them with properties of the Export class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-17 00:11:09 -03:00
Maurício Meneghini Fauth
569df15d3e
Rename Export class variables to use camel case
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-16 19:08:18 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
f2e49a92c6
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Nikkolai Fernandez
aa8c4a773c
Remove inline js ( #16308 )
...
* Removed inline onclick javascript
Signed-off-by: Nikkolai Fernandez <nikkolaifernandez14@gmail.com>
2020-08-19 12:52:36 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
737f90e2c0
Remove exit from Export::showPage method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-09 16:41:45 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 15:25:56 +02:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
8dd310fb6a
Remove assignments in if conditions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:35:19 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
8a86ffc993
Add some notes for the translators about source translations
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-13 21:49:15 +01:00
William Desportes
ba8946d5f8
Move some code to getFinalFilenameAndMimetypeForFilename and add tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-27 21:16:37 +01:00
William Desportes
501397a5d6
Add a message when the plugin does not support the export method
...
Example:
- no db, table selected.
- Type a raw query, export using codegen.
- See error message
CodeGen can not export if it does not have db and table params
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-27 21:16:37 +01:00
William Desportes
0adb361d3c
Some code fixes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-27 21:16:36 +01:00
Saurabh Srivastava
1b56c8e0ed
Fix 15064 - instead of using free_query parameter, now updating export_type to raw -- more modular approach
...
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2020-01-27 21:16:31 +01:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
8ec4209002
Fix some coding standard issues
...
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
4ffb6712ff
Remove the table export entry point file
...
Directly calls the controller instead of including the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
bb42779331
Remove the database export entry point file
...
Directly calls the controller instead of including the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
bce0245387
Remove the server export entry point file
...
Directly calls the controller instead of including the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a
Remove useless parentheses
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
f6a17433a2
Use null coalesce operator when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
803d07d868
Merge branch 'QA_5_0' into 'master'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 14:19:56 +02:00
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
...
- Fixed css img urls for designer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
...
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs
Fixes : #15446
Fixes : #13370
Fixes : #14945
Closes : #15438
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
Maurício Meneghini Fauth
3262a276e8
Use the router for the export entry point
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 12:25:01 -03:00
Maurício Meneghini Fauth
fb6fcec5f5
Use the router for the table export page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 12:10:17 -03:00
Maurício Meneghini Fauth
86d78c547f
Use the router for server export page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 11:50:06 -03:00
Maurício Meneghini Fauth
ef81c86830
Use the router for the database export page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-17 11:38:55 -03:00
Hugues Peccatte
6ddb9b3a22
Use right order of parameters for implode
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
c8f84fc748
Replace is_null with identical comparison with null
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
7be0f6bfae
Reference class names in use statements
...
Sort use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00