gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
124,832 Commits 12 Branches 481 Tags 2.4 GiB
c958e27bfa
Commit Graph

124832 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
aliber4079
c958e27bfa
fix #17779 - PHP 8 numeric operation (#17827) 
Fixes #17779

php8 throws exception in spite of @ symbol so work around it

Signed-off-by: Alex Liberman <alex@zoosmart.us>
 2022-11-05 14:46:58 -03:00
Maurício Meneghini Fauth
04042517a5
Update PHPStan baseline 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-05 14:38:06 -03:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870) 
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 13:04:45 -03:00
Kamil Tekiela
95a93ba909
Minor stylistic changes (#17865) 
* Stylistic changes to make refactoring easier
* Parameter $where was unnecessarily nullable
* Refactor Routines::getDetails()
* Refactor Events::getDetails()
* Refactor Triggers::getDetails()
* Split up QueryGenerator::getInformationSchemaColumnsFullRequest

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 12:55:44 -03:00
Maurício Meneghini Fauth
0bd9391476
Merge pull request #17862 from kamil-tekiela/Refactor-displayHtmlForColumnChange 
Refactor ChangeController and use ServerRequest
 2022-11-05 12:49:55 -03:00
Maurício Meneghini Fauth
a229f313ed
Merge pull request #17859 from kamil-tekiela/more-globals 
Fix Replica bugs

Fixes #17849
Closes #17856
 2022-11-05 12:31:43 -03:00
William Desportes
56801fa996
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 21:36:50 +01:00
William Desportes
e99bfaee4b
Add a ChangeLog entry for #17777 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 21:35:33 +01:00
William Desportes
9b700c6307
Merge #17852 - Fix #17777 - Uncaught TypeError: Cannot read properties of null (reading 'inline') 
Pull-request: #17852
Fixes: #17777

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 21:34:06 +01:00
vimal K
fb0feafb7f
Uncaught TypeError: Cannot read properties of null (reading 'inline') #17777 
Signed-off-by: Vimal K <vimalinfo10@gmail.com>
 2022-11-03 21:30:02 +01:00
William Desportes
3a7b77d22e
Update psalm baseline 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 20:43:34 +01:00
William Desportes
5135b798a8
Merge remote-tracking branch 'origin/master' 2022-11-03 20:43:06 +01:00
William Desportes
c00a904827
Merge #17864 - Fix #17793 - insert record - fix null not selected if nullable UUID & insert error 
Pull-request: #17860
Fixes: #17793

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 20:36:55 +01:00
William Desportes
110b609e92
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 20:35:10 +01:00
William Desportes
296e6b62ce
Update phpstan and psalm baseline 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 20:29:19 +01:00
William Desportes
5e1ff822f3
Merge #17860 - Fix #17793 - insert record - fix null not selected if nullable UUID & insert error 
Pull-request: #17860
Fixes: #17793

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-03 20:24:12 +01:00
Maurício Meneghini Fauth
e2274846c0
Update PHPStan baseline 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-03 16:22:28 -03:00
Maurício Meneghini Fauth
efbd8d835a
Merge pull request #17855 from kamil-tekiela/globals-DBI 
Reduce usage of $GLOBALS['dbi']
 2022-11-03 15:48:20 -03:00
Mo Sureerat
a36ee101e7 [ISSUE-17793] Remove unreachable condition 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-04 01:23:33 +07:00
Mo Sureerat
8929288efd [ISSUE-17793] Add more test for coverage 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-04 00:33:41 +07:00
Mo Sureerat
05552b6271 [ISSUE-17793] Fix static analysis warning 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 23:08:23 +07:00
Mo Sureerat
e2e92c6899 [ISSUE-17793] Fix lint check fail 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 23:08:03 +07:00
Mo Sureerat
250be6adbc [ISSUE-17793] Fix static analysis warning 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 22:57:07 +07:00
Mo Sureerat
15e629c9c1 [ISSUE-17793] UUID - Fix insert error 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 05:55:37 +07:00
Mo Sureerat
ddf928e6f3 [ISSUE-17793] Revert previous change + Fix default selection of uuid in alter table 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 05:25:14 +07:00
Mo Sureerat
f8bee4cd5d [ISSUE-17793] Insert record - fix null not selected if nullable UUID + insert error 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 05:25:04 +07:00
Mo Sureerat
afd568e889 [ISSUE-17793] Revert previous change + Fix default selection of uuid in alter table 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 05:11:19 +07:00
Kamil Tekiela
b3d97a47ef Refactor ChangeController and use ServerRequest 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 21:57:31 +00:00
Mo Sureerat
7615c7e780 [ISSUE-17793] Insert record - fix null not selected if nullable UUID + insert error 
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
 2022-11-03 03:01:38 +07:00
Kamil Tekiela
7ee4c77036 Fix Replica bugs 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:47:31 +00:00
Kamil Tekiela
a5a81d159f Send DBI to Data using DI 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:15:58 +00:00
Kamil Tekiela
15915a45e0 Send DBI to SqlQueryForm using DI 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:15:58 +00:00
Kamil Tekiela
828a5f7137 Update Privileges.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:15:58 +00:00
Kamil Tekiela
e62241b079 Update Routines.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:15:58 +00:00
Kamil Tekiela
98902c87a8 Update Designer.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-02 15:15:58 +00:00
Kamil Tekiela
8caf17b0ac SystemDatabase 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-01 16:33:03 +00:00
Maurício Meneghini Fauth
bfe59e6e41
Merge pull request #17837 from MauricioFauth/core-fatal-error-removal 
Replace `PhpMyAdmin\Core::fatalError()` method calls
 2022-10-31 22:37:03 -03:00
Maurício Meneghini Fauth
c88152cf59
Use more specific exceptions for some errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 22:32:12 -03:00
Maurício Meneghini Fauth
de03f00cae
Remove Core::fatalError method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 22:18:47 -03:00
Maurício Meneghini Fauth
640ecc5c08
Remove $message_args param from Core::fatalError() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 21:49:54 -03:00
Maurício Meneghini Fauth
66e2650e06
Replace Core::fatalError() calls in controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
103968f352
Replace fatalError() with exception in Core::warnMissingExtension() 
Also moves some other calls to Core::warnMissingExtension() to the
Common::checkRequiredPhpExtensions() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
3121dae621
Replace Core::fatalError() calls from the Common class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:25:54 -03:00
Maurício Meneghini Fauth
62530b48a5
Replace Core::fatalError with an exception in Export::processExportSchema() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:25:51 -03:00
Maurício Meneghini Fauth
128211ccc9
Remove Core::fatalError call from SchemaExportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:24:20 -03:00
Maurício Meneghini Fauth
25fe766a26
Fix tests marked as incomplete 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 20:22:54 -03:00
William Desportes
bff74dc588
Fix #17705 - CodeMirror query box has overflow preventing click 
Fixes: #17705

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-01 00:21:30 +01:00
Maurício Meneghini Fauth
91403fc519
Update Psalm baseline 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-31 19:59:54 -03:00
pistej
1d619c11ad
Ref #17769 - ServerRequest Object instead superglobals - DB controllers (#17854) 
* Use ServerRequest Object instead superglobals - DB controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

* fixed phpstan

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-31 19:51:28 -03:00
Maurício Meneghini Fauth
40c6614c3a
Merge pull request #17853 from pistej/globals-to-req-db-structure-1 
Ref #17769 - Use ServerRequest Object instead superglobals - DB/structure controllers
 2022-10-31 19:50:04 -03:00