Commit Graph

280 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
7db0debd05
Fix some failing tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:51:51 +02:00
Maurício Meneghini Fauth
4a0bce1d53 Extract db structure bulk actions from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-22 23:13:35 -03:00
William Desportes
8e9553e8d7
Merge #16082 - Fix #15995 - database export
Pull-request: #16082
Fixes: #15995

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 00:40:18 +02:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 20:15:42 -03:00
Maurício Meneghini Fauth
603c357d05 Refactor Database\EventsController::index method
Moves Database\Events::main into index method.
Uses DI for Events instance.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 19:38:50 -03:00
Hugues Peccatte
b0460d3aa3 Fix #15995 database export
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2020-04-15 20:56:40 +02:00
Maurício Meneghini Fauth
1102bdfdb7 Move Rte classes to the Database namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 18:26:47 -03:00
Maurício Meneghini Fauth
92bc73483e Remove the $_PMA_RTE global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 17:23:51 -03:00
Maurício Meneghini Fauth
c1ca032da7 Use DI for RTE classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-11 16:09:35 -03:00
Maurício Meneghini Fauth
8732435e64 Extract HTML from indexes table of data dict page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-29 20:03:28 -03:00
Maurício Meneghini Fauth
f705e32a47 Replace fieldset with cards for db operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-21 00:38:50 -03:00
Maurício Meneghini Fauth
a989348986 Extract HTML from QueryByExampleController::index
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-15 01:16:58 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
Maurício Meneghini Fauth
d85cca09b2 Remove database and table from route names
Database and table names may contain the slash char (/) which is the
route separator char.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 17:26:02 -03:00
Maurício Meneghini Fauth
64723d90da Rename the multi-table query route
Renames the route name from /database/multi_table_query to
/database/multi-table-query.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 17:04:59 -03:00
Maurício Meneghini Fauth
8029ea9875 Move request handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c Move response handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
William Desportes
a7a7b73b55
Support return back from raw export
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-27 21:16:37 +01:00
Saurabh Srivastava
1b56c8e0ed
Fix 15064 - instead of using free_query parameter, now updating export_type to raw -- more modular approach
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2020-01-27 21:16:31 +01:00
Maurício Meneghini Fauth
aa0f8a6efe Extract HTML from the database operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 22:56:29 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
William Desportes
1af14d25f8
Fix coding standard issue issue introduced by #15432
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-15 19:51:26 +01:00
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
William Desportes
0ae945f1f5
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-11 16:29:24 +01:00
Maurício Meneghini Fauth
d0f28cef30 Refactor table pages common code
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
385e7f86c0 Refactor database pages common code
Extracts db_common.inc.php code to the Common::database() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
aaab14284f Remove requires from the routes file
Call the the controller directly instead of requiring the entry point
file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 11:02:41 -03:00
Maurício Meneghini Fauth
09daab7ba9 Refactor Database\SqlController controller
Moves the database sql entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-03 15:07:27 -03:00
Maurício Meneghini Fauth
e9216ad486 Create Database\ExportController controller
Extracts the database export entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-03 11:23:31 -03:00
William Desportes
666e06904d
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 17:38:28 +01:00
William Desportes
8033c15fe6
Fix #15722 - Get Database structure fails with PHP error on replicated server
Fixes: #15722
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 17:37:49 +01:00
Maurício Meneghini Fauth
5debd00bd0 Create Database\ImportController class
Moves the database import entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-29 20:22:21 -03:00
Maurício Meneghini Fauth
693bf67b1c Refactor Database\CentralColumnsController class
Moves the central columns entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 12:51:35 -03:00
Maurício Meneghini Fauth
7112434f51 Create Database\TrackingController controller
Moves the database tracking entry point logic to the
Database\TrackingController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-21 18:07:27 -03:00
Maurício Meneghini Fauth
8083de3a01 Create Database\SqlFormatController class
Moves sql format entry point logic to the SqlFormatController controller
and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-21 17:33:37 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
301835e9a6 Create SqlAutoCompleteController
Moves database sql autocomplete entry point logic to the
Database\SqlAutoCompleteController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 18:22:52 -03:00
Maurício Meneghini Fauth
fa6fc404fe Create Table\TriggersController
Moves database|table triggers entry point logic to
Database|Table\TriggersController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 17:53:18 -03:00
Maurício Meneghini Fauth
8a800070bd Moves db routines entry point logic to the controller
Removes the database routines entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 11:38:32 -03:00
Maurício Meneghini Fauth
958ba8822d Create Database\OperationsController
Moves database operations entry point logic to the
Database\OperationsController controller and removes the entry point
file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-09 18:12:00 -03:00
Maurício Meneghini Fauth
2f3f768357 Refactor Controller\Database\EventsController
Moves database events entry point logic to the Database\EventsController
controller and remove the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-08 16:57:07 -03:00
Maurício Meneghini Fauth
351e34ecf5 Upgrade PHPStan to version 0.12.0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-07 20:26:39 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
a0a44fd01e Move db search entry point logic to a new controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-30 18:49:57 -03:00
Maurício Meneghini Fauth
fcde861b97 Move db qbe entry point logic to a new controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-28 20:43:56 -03:00
Maurício Meneghini Fauth
b3b3d5efd2 Move db designer entry point logic to a controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-26 20:57:50 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
acd62791b8 Move database structure entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-03 21:01:00 -03:00
Maurício Meneghini Fauth
5227fbf26b Move database multi table query entry point to routes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-02 21:54:09 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534)
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
998d833c0c Move database data dictionary to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 19:53:21 -03:00
Maurício Meneghini Fauth
672aee2d8a Create Database\PrivilegesController
Extracts Server\Privileges::getHtmlForSpecificDbPrivileges method to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 21:09:24 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
efe576cdc0 Fix double encoding in database struture page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-22 23:24:52 -03:00
Maurício Meneghini Fauth
aec0402679 Use the router for table structure page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-19 20:18:06 -03:00
Maurício Meneghini Fauth
682e7a160e Use the router for database structure page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-18 14:33:43 -03:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
0feae32056 Rename Sanitize::sanitize to Sanitize::sanitizeMessage
...to avoid the PHP 4 constructor format

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 15:21:48 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
William Desportes
96fc4d45af
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-03 21:29:07 +02:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Eugene Kazakov
9edcc5e43a Bug #10846 TypeError: Cannot read property 'substring' of undefined
Signed-off-by: Eugene Kazakov <ekazakov@plesk.com>
2019-05-31 18:21:30 +02:00
Maurício Meneghini Fauth
dfd49d16b8 Fix ESLint warnings in js/functions.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-30 17:30:16 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 00:34:57 +02:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 22:31:29 +01:00
Maurício Meneghini Fauth
4d9da96469 Create server, database and table SqlControllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-23 22:41:29 -03:00
Maurício Meneghini Fauth
f1f109ac26 Create Database\MultiTableQueryController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-22 12:22:27 -03:00
Maurício Meneghini Fauth
a9115725b2 Create database RTE controllers
- Create PhpMyAdmin\Controllers\Database\RoutinesController
- Create PhpMyAdmin\Controllers\Database\TriggersController
- Create PhpMyAdmin\Controllers\Database\EventsController
- Remove libraries/rte/rte_main.inc.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-22 02:35:45 -03:00
Maurício Meneghini Fauth
c9371d3a91 Rename Controller to AbstractController
Rename PhpMyAdmin\Controllers\Controller to
PhpMyAdmin\Controllers\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:57:14 -03:00
Maurício Meneghini Fauth
0305c0a2c2 Rename Database\Controller to Database\AbstractController
Rename PhpMyAdmin\Controllers\Database\Controller to PhpMyAdmin\Controllers\Database\AbstractController

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:04:28 -03:00
Maurício Meneghini Fauth
50ec2c0e2b Create Controllers\Database\CentralColumnsController
Moves db_central_columns.php logic to the controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-05 02:12:12 -03:00
Maurício Meneghini Fauth
e700760685 Refactor Controllers\Database\StructureController
Move request and response handling to db_structure.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-03 23:20:48 -03:00
Maurício Meneghini Fauth
35fafd773a Create Controllers\Database\DataDictionaryController
- Extracts db_datadict.php logic to the controller
- Extracts HTML to database/data_dictionary/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-01 23:06:13 -03:00
Maurício Meneghini Fauth
4c93203904 Rename DatabaseController and TableController
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-27 22:52:36 -03:00
Maurício Meneghini Fauth
067a6bfa0b Rename DatabaseStructureController to StructureController
Renames PhpMyAdmin\Controllers\Database\DatabaseStructureController to
PhpMyAdmin\Controllers\Database\StructureController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 21:58:47 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
76fbe019da
Merge pull request #14856 from Tithugues/fix/escape-also-delimiter
Escape also delimiter
2019-01-16 02:19:24 -03:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Hugues Peccatte
280926e3f3 Escape also delimiter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:38:39 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
Leonardo Strozzi
c03214780d Refactor Database Structure templates
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-20 22:46:44 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Leonardo Strozzi
5d0fd81e67 Remove Twig php function extensions
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-29 23:06:31 -03:00
Maurício Meneghini Fauth
2d5825d73e
Merge pull request #14305 from laps15/refactor
Remove md5 twig extension
2018-05-22 23:01:52 -03:00
Maurício Meneghini Fauth
dce862d41b Remove dbi global from Controllers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-22 16:51:03 -03:00
Leonardo Strozzi
927fed774c Remove md5 twig extension
Adapt templates to remove md5 from PhpFuncionsExtension.php

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-05-22 07:54:03 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
5f46a4ba52 Enable strict mode in Controllers classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:18:52 -03:00
Maurício Meneghini Fauth
d758e062a9 Refactor PhpMyAdmin\Replication methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-13 18:21:55 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Xinyu Liu
7391d872a9 Fix improperly escaped HTML code in database structure page #14071
Signed-off-by: Xinyu Liu <meteor.lxy@foxmail.com>
2018-03-19 08:06:33 +00:00
Michal Čihař
c162a75b9b Improve javascript loading
- jquery-ui-timepicker-addon.js is loaded in Header, no need to load it
  elsewhere
- jquery.validate.js is needed on way to many pages to benefit of
  loading only on some of them

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 08:36:23 +01:00
Michal Čihař
77f0d50bea Add missing dependency on jquery.validate.js
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 15:09:43 +01:00
Michal Čihař
f859a9701d Rewrite selection of tables with overhead
Avoid using inline generated javascript, use CSS selectors instead.

Issue #12782

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-30 12:19:38 +01:00
Maurício Meneghini Fauth
a75010c8b9 Port database/structure/table_header to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-24 22:27:02 -02:00
Maurício Meneghini Fauth
a13fd4835a Port database/structure/body_for_table_summary to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-24 00:54:16 -02:00
Maurício Meneghini Fauth
09b3488fe4 Port database/structure/structure_table_row to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-18 21:19:52 -02:00
Maurício Meneghini Fauth
62197a88a6 Port database/structure/check_all_tables to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-17 16:17:47 -02:00
Maurício Meneghini Fauth
47af251acc Port database/structure/favorite_anchor to Twig
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-11 23:18:57 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
96223ca40b Refactor replication functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-13 13:12:25 -03:00
Maurício Meneghini Fauth
512d81cb29 Refactor display_create_table to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-07 09:37:02 -03:00
Michal Čihař
94bb2e31a1 Remove no longer needed page_settings.forms.php and user_preferences.forms.php
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:04:47 +02:00
Michal Čihař
0b81218a10 Refactor configuration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:44:05 +02:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Maurício Meneghini Fauth
95a409c4f2 Move controllers to PhpMyAdmin namespace
- Move base controllers to PhpMyAdmin namespace
- Move database controllers to PhpMyAdmin namespace
- Move server controllers to PhpMyAdmin namespace
- Move table controllers to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-14 11:18:48 -03:00