gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
113,630 Commits 12 Branches 481 Tags 2.4 GiB
e7d36c2ff6
Commit Graph

552 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
d243f7ccd6 Enable strict mode in libraries files 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 03:20:45 -03:00
CommanderRoot
ceed1d6459
Fix errors due to undefined variables 
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
 2018-04-18 20:07:36 +02:00
Maurício Meneghini Fauth
65c5a13deb Remove hash_equals polyfill 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-13 02:33:10 -03:00
Maurício Meneghini Fauth
1a107ac92e Upgrade to PHP 7.1 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 20:23:56 -03:00
Maurício Meneghini Fauth
d23ed47666 Refactor PhpMyAdmin\IpAllowDeny static methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-03 14:06:13 -03:00
Maurício Meneghini Fauth
767f0731e9
Merge pull request #13983 from nulll-pointer/contribution 
Fix for broken profiling; issue #13969 
Fix #13969
 2018-02-16 11:33:18 -02:00
Maurício Meneghini Fauth
235b0e9631 Fix case in which checkServers is never called 
If there is no configuration file, the checkServers() method will never be called.

Fix #13769

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-10 16:47:18 -02:00
Lakshay arora
463321a6d5 Fix for issue #13969 
Changed file ./libraries/common.inc.php
Removed member header from line '$response->getHeader()->header->getScripts()', there is no such member.
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)
 2018-02-10 05:03:00 +05:30
Michal Čihař
0a1634a12b Warn user in case the failed login is result of failed setting of cookie 
This can easily happen when switching between HTTPS and HTTP - once you
login using HTTPS, the secure cookie is created and it can not be
overwritten by non secure one created on HTTP connection making the
browser stuck on wrong session ID.

Issue #13872

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-18 11:35:44 +01:00
Michal Čihař
72f109a99c Accept SQL query only from POST requests 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-14 10:34:45 +01:00
Michal Čihař
3b6a994dcd Move collation connection setting to user preferences 
It is now handled same way as other user settings.

Issue #11688
Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-29 14:16:31 +01:00
Michal Čihař
d76606a869 Remove cookie cleanup code 
We no longer store any structured information in the cookies, so the
upgrade path is not really needed. Also this can cause problems with
third party integrations.

Issue #11688
Fixes #13480

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-28 15:51:33 +01:00
Michal Čihař
d3f9075165 Load user preferences at one place 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 17:06:24 +01:00
Michal Čihař
73f428e568 Remove hack for navigation and server switching 
It is not really used with current navigation, so this code has no use
for years.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 17:02:27 +01:00
Michal Čihař
2bc8afea5f Move storage zeroconfig to the DBI post connect 
This way it is executed only when needed.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 17:00:23 +01:00
Michal Čihař
738f527242 Move goto_whitelist to the core class 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 16:49:24 +01:00
Michal Čihař
4d9b63fa99 Remove global variables cleanup 
This should be no longer necessary, it was really a workaround for
grab_globals, which is not present in PHP for years.

See ee3825013d

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 16:49:19 +01:00
Michal Čihař
3b9fb2b664 Simplify handling of long URLs in Util::linkOrButton 
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:33:53 +01:00
Michal Čihař
5acd64f84d Use two-factor authentication instead fo second authentication factor 
This is probably more widely used naming.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-02 09:05:18 +01:00
Michal Čihař
a646d4314e Add generic interface for second authentication factor 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-01 16:34:14 +01:00
Michal Čihař
e19f3599a4 Remove not needed plugin manager for authentication 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-30 14:03:51 +01:00
Michal Čihař
329ce22b73 Correctly handle fallback control user connection using user parameters 
Remember it as CONNECT_CONTROL and avoid running post connect handler.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-25 10:21:18 +02:00
Michal Čihař
60c1b32472 Remove usage of $GLOBALS['userlink'] 
The links are internal to DatabaseInterface and user link is default.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-25 10:21:18 +02:00
Scrutinizer Auto-Fixer
40f56c0a95 Remove not needed use statements 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-23 18:49:37 +02:00
Michal Čihař
5d9e124449 Move timezone setup to the DatabaseInterface 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-23 11:34:49 +02:00
Michal Čihař
d3be81a8c9 Fix comment 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-23 11:30:42 +02:00
Michal Čihař
c1375f4e84 Remove not needed access through globals 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-20 19:44:28 +02:00
Michal Čihař
62535ea5b9 Pass failure reason to showFailure 
This way we can avoid relying on global variables to check it.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-20 19:44:28 +02:00
Michal Čihař
2327dbf3c3 Move allow/deny rules check to AuthenticationPlugin 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-20 18:14:56 +02:00
Michal Čihař
9bc5bfd74c Move authentication logic to AuthenticationPlugin 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-20 18:14:56 +02:00
Michal Čihař
026d722178 Rationalize AuthenticationPlugin API 
Make the API more consistent, remove not needed auth prefix and stop
talking about advanced authentication which has been there about 10
years ago.

API changed:

- authCheck is now readCredentials
- authSetUser is now storeCredentials
- auth is now showLoginForm
- authFails is now showFailure
- storeUserCredentials is now rememberCredentials

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-20 18:14:56 +02:00
Michal Čihař
d1f98f85f8 Simplify authentication plugin handling 
- rely on autoloader to figure out filename
- directly contruct full class name

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-20 15:41:56 +02:00
Michal Čihař
b6ab344e6f Move request check to helper method 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-20 15:41:16 +02:00
Michal Čihař
9fd9e5d9b3 Remove not needed intermediate variable 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 14:17:53 +02:00
Michal Čihař
b97116cd5a Remove no longer needed conditions 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 14:17:20 +02:00
Michal Čihař
64f4b2cb08 Avoid using PMA_BYPASS_GET_INSTANCE 
We can use Response::disable instead.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 14:14:39 +02:00
Michal Čihař
56eee83f39 Remove cell_align_right superglobal 
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 13:15:41 +02:00
Michal Čihař
e4ca1ae98f Remove cell_align_left superglobal 
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 13:04:45 +02:00
Michal Čihař
98964e2f59 Remove is_superuser superglobal 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 12:28:00 +02:00
Michal Čihař
9c9c22e516 Load SQL parser context in DatabaseInterface::postConnect 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 12:10:40 +02:00
Michal Čihař
d574aede08 Bind Types to DatabaseInterface 
This wayt it's automatically passed with DBI.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 12:05:02 +02:00
Michal Čihař
b5e391f006 Merge Types and TypesMySQL classes 
These were separate from time we've supported Drizzle, but this no
longer makes sense.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 11:33:45 +02:00
Michal Čihař
ac856175a6 Move server selection to Config class 
- move server selection from common.inc.php to Config class
- add tests covering most usual cases

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-03 19:14:38 +02:00
Michal Čihař
d2d32651bc Replace empty() by strlen() 
In order to fix operation with database or table called 0.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-02 15:53:44 +02:00
Maurício Meneghini Fauth
387e23a097 Move DbList to Database/DatabaseList 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-26 22:00:39 -03:00
Maurício Meneghini Fauth
7bd3a54cbb Refactor ip_allow_deny functions to static methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-12 12:01:57 -03:00
Michal Čihař
a82f8fc768 Move databaase interface load to static method 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-06 14:46:56 +02:00
Michal Čihař
94bb2e31a1 Remove no longer needed page_settings.forms.php and user_preferences.forms.php 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-06 11:04:47 +02:00