gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
122,906 Commits 12 Branches 481 Tags 2.4 GiB
e8bfa5e4e6
Commit Graph

21557 Commits

Author SHA1 Message Date
Kamil Tekiela
e8bfa5e4e6 Remove redundant condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
51207fff0b Set parameter type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
7b60bd57fa Remove unused pass-by-ref 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
53518dc266 Fix argument type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
1df141dcd6 Remove unused parameter 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
aa49e38fc0 Invert the condition within foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:13 +00:00
Kamil Tekiela
18a16915df Use elvis operator instead of if 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
c9a532dcaf Remove useless ! empty 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
1e2772dbff Convert ternary into true boolean expression 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
34b0a92a87 Merge if statements into one 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Kamil Tekiela
b1a82bf08b Refactor Sql.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-07 22:31:12 +00:00
Maurício Meneghini Fauth
290f026a02
Merge pull request #17272 from kamil-tekiela/queryAsControlUser 
Query as control user
 2022-01-06 21:32:46 -03:00
Kamil Tekiela
73b7094b2b Remove redundant isset 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Kamil Tekiela
9afa59487e Collapse if statements into one 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:22 +00:00
Kamil Tekiela
202b17c34c Replace if with coalesce 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
6e8a04c4ab Remove redundant condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
0cd422954b Remove redundant arguments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
75b5c3241c Remove optional $onclick parameter 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
cf16a3c55a Remove redundant parentheses 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
af4b8938b8 Collapse if statements into one 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
4c22cf1f13 Remove pass-by-ref 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
1468976587 Convert phpdoc to param type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
5883ca608e Add param and return type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:21 +00:00
Kamil Tekiela
d5dbc316c0 Remove matching default values 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:38:20 +00:00
Kamil Tekiela
415eb2c8d7 Convert ternary to boolean expression 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:37:35 +00:00
Kamil Tekiela
a4cb49080a Extract common part from if 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:37:35 +00:00
Kamil Tekiela
01438e9d7a Update docblocks for nullable parameters 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:37:34 +00:00
Kamil Tekiela
84eba89cd2 Remove pass-by-ref 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:37:34 +00:00
Kamil Tekiela
9a34ec9fdf Remove invalid condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:37:34 +00:00
Kamil Tekiela
a74c5aed44 Add few more usages of queryAsControlUser 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-06 19:31:27 +00:00
Kamil Tekiela
f38d3baa31 Remove $options parameter from fetchResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:17 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED 
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
b1dc03365a
Bump TCPDF version to 6.4.4 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-31 16:58:34 -03:00
Maurício Meneghini Fauth
cb650d2a2d
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-29 19:44:12 -03:00
William Desportes
679eca275a
Fix phpdocs after tcpdf update to 6.4.3 (the actual hints where not valid) 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-12-29 01:41:58 +01:00
Maurício Meneghini Fauth
58ed5bfa9e
Extract Simulate DML action from ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 18:37:15 -03:00
Maurício Meneghini Fauth
0f678e8d7d
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 16:19:18 -03:00
Maurício Meneghini Fauth
3968808e76
Fix broken link in the Simulate DML query modal 
Fixes #17259

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 16:09:07 -03:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
2d56a8baac
Move Import and ImportStatus ctrls to Controllers\Import ns 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 10:27:28 -03:00
Maurício Meneghini Fauth
2edf663611
Remove the Bookmark::getParams method 
Uses BookmarkFeature class instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 09:31:53 -03:00
Maurício Meneghini Fauth
8e9dfe79db
Merge pull request #17243 from kamil-tekiela/Refactor-Results.php 
Refactor results.php
 2021-12-27 09:21:49 -03:00
Kamil Tekiela
e2dc2a9c86 Remove getUnsortedSqlAndSortByKeyDropDown() 
This was stupid abstraction. This method did 2 things. When the code that prepares unsorted SQL is moved out of this method, the rest can be absorbed by getSortByKeyDropDown(). This method didn't declare any local variables, it took parameters that were just passed along to other methods. The code to get unsorted SQL was just a single instruction that was self-explanatory. Indexes relied on properties so they didn't need to be a parameter to the other method.

This method only added complexity instead of reducing it.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
7a735ddf92 Redesign CSS class generation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
9969b9d103 $printview global is always null 
The variable is not set anywhere in the current codebase.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
acb91c0b34 Refactor Results.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
97810b3a21 Fix bug #17239 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00
Kamil Tekiela
eba8621881 Use DI for Results.php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-26 23:10:34 +00:00