Commit Graph

127066 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
f570bf64bf
Pass ServerRequest object to Indexes::doSaveData() method
This removes the need to call Application::getRequest().

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 13:17:12 -03:00
Maurício Meneghini Fauth
e8ebb663cc
Merge pull request #18602 from MauricioFauth/db-table-exists-refactor
Refactor the DbTableExists class
2023-08-06 01:42:59 -03:00
Maurício Meneghini Fauth
63e6410728
Refactor the DbTableExists class
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 01:42:06 -03:00
phpMyAdmin bot
d097166828 Update po files
[ci skip]

Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2023-08-06 00:18:36 +00:00
Maurício Meneghini Fauth
4dbe1b6e4b
Merge pull request #18562 from MoonE/scale-data
Refactor / rename in Gis
2023-08-05 20:18:57 -03:00
Maurício Meneghini Fauth
d05bb47a0b
Merge pull request #18601 from kamil-tekiela/Refactor-indexes
Refactor indexes
2023-08-05 19:58:01 -03:00
Kamil Tekiela
2b4916351e Introduce param $oldIndexName
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-05 20:33:20 +01:00
Kamil Tekiela
22c815e647 $request->hasBodyParam('preview_sql')
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-05 20:23:54 +01:00
Kamil Tekiela
e5701885b7 Flatten if statement
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-05 20:23:54 +01:00
Maurício Meneghini Fauth
bfc3852e61
Create Http\Response::write() method to write to the body
This method helps when data is written to the body of the response and
the response object is returned immediately.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-05 10:50:53 -03:00
Maurício Meneghini Fauth
d89bb277d0
Replace some 'echo' with ResponseRenderer::addHTML() method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-04 22:07:25 -03:00
Maurício Meneghini Fauth
41996de092
Merge pull request #18594 from kamil-tekiela/Fix-SA-reported-issues
Fix SA reported issues
2023-08-04 20:05:20 -03:00
Maurício Meneghini Fauth
e436ad23ec
Merge pull request #18598 from kamil-tekiela/charset_connection
Remove globals charset_connection & collation_connection
2023-08-04 20:00:10 -03:00
Maurício Meneghini Fauth
234809d47c
Merge pull request #18599 from MauricioFauth/export-show-page-redirect
Change export to server file to use redirection after save
2023-08-04 19:59:01 -03:00
Maurício Meneghini Fauth
f3b57f6278
Change export to server file to use redirection after save
Removes the need of calling other controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-04 17:52:25 -03:00
Kamil Tekiela
47959814a4 Remove globals charset_connection & collation_connection
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-04 21:32:05 +01:00
Maurício Meneghini Fauth
eff6872c83
Fix PHPUnit 10.3 soft deprecations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-04 13:58:06 -03:00
Kamil Tekiela
a8a3986a80 Provide more accurate type hints
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-03 20:41:29 +01:00
Kamil Tekiela
3421e591dd in_array should use strict mode
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-03 20:41:28 +01:00
Kamil Tekiela
8774891531 $pattern must be non-empty-string
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-03 20:41:28 +01:00
William Desportes
eae978f3f3
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-08-03 15:01:31 +02:00
William Desportes
7c975030b9
Fix #18592 - Remove instruction to remove the pma_collation_connection cookie removed in 4.8.0
Ref: 3b6a994dcd
Fixes: #18592

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-08-03 15:00:19 +02:00
Maurício Meneghini Fauth
6df6a543e7
Update Psalm baseline
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-31 14:05:34 -03:00
Maurício Meneghini Fauth
45b58d7eea
Refactor JavaScriptMessagesController to return a Response object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-30 17:22:18 -03:00
Maurício Meneghini Fauth
f72a07a82c
Merge pull request #18590 from kamil-tekiela/Remove-func_overload-check
Remove func_overload check
2023-07-30 00:57:52 -03:00
phpMyAdmin bot
e27ad234d0 Update po files
[ci skip]

Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2023-07-30 00:21:21 +00:00
Kamil Tekiela
e7ea833566 Move checkServerConfiguration before ini_set
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-30 00:10:00 +01:00
Kamil Tekiela
68569a97c5 Remove func_overload check
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-30 00:09:59 +01:00
Maurício Meneghini Fauth
a55a4cba2b
Extract dbi calls from body_for_table_summary template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-28 19:58:03 -03:00
Maurício Meneghini Fauth
d9d47ba3ab
Merge pull request #18587 from MauricioFauth/show-config-errors-file-removal
Remove the public/show_config_errors.php file
2023-07-28 19:29:33 -03:00
Maurício Meneghini Fauth
bd3d0a6c03
Merge pull request #18585 from kamil-tekiela/$triggers-!==-]
Redesign Triggers::getDetails()
2023-07-28 18:37:03 -03:00
Kamil Tekiela
93263d9ce3 Redesign Triggers::getDetails()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-28 22:28:24 +01:00
Maurício Meneghini Fauth
44f7e93b36
Remove the public/show_config_errors.php file
A better and safer way of showing the configuration errors should be
developed.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-28 16:30:22 -03:00
Maurício Meneghini Fauth
a295159c64
Merge pull request #18393 from kamil-tekiela/Remove-Session-cache-in-Relation
Remove session cache in relation
2023-07-27 17:29:33 -03:00
Maurício Meneghini Fauth
c7b92d2de9
Merge pull request #18576 from MauricioFauth/app-http-handler
Wrap the Application::run() code with a HTTP handler
2023-07-27 12:31:36 -03:00
Kamil Tekiela
05e7123a08 Make broken test pass
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-27 12:02:12 +01:00
Kamil Tekiela
1a2d2a472b Remove session cache in Relation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-27 12:02:12 +01:00
Kamil Tekiela
8bdcd9074d Don't invoke Triggers::getDetails twice
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-27 11:37:50 +01:00
Kamil Tekiela
67ccdc3905 Extract SQL into QueryGenerator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-27 11:37:50 +01:00
Kamil Tekiela
081d8bb60b Extract code to a private method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-27 11:37:50 +01:00
Kamil Tekiela
65e6c5fba9 Use strict array check with $triggers
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-27 11:37:50 +01:00
Maurício Meneghini Fauth
2c90f397e1
Refactor the Setup\MainController controller
Changes the __invoke() method so it returns a Response object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-26 21:33:43 -03:00
Maurício Meneghini Fauth
6597dee724
Refactor the Routing::callSetupController() method
Changes the method so it return a Response object when possible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-26 21:33:43 -03:00
Maurício Meneghini Fauth
fb39be0a77
Refactor the Routing::callControllerForRoute() method
Changes the method to return a Response object when possible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-26 21:33:40 -03:00
Maurício Meneghini Fauth
ecf1c78ae8
Wrap the Application::run() code with a HTTP handler
- Uses laminas-httphandlerrunner to emit the Response object

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-26 21:31:49 -03:00
Maurício Meneghini Fauth
0b9db09812
Merge pull request #18581 from MauricioFauth/request-is-ajax
Add a isAjax() method to ServerRequest class
2023-07-26 21:14:06 -03:00
Maurício Meneghini Fauth
bd20426c70
Merge pull request #18575 from kamil-tekiela/morepagestable-float
Pdf::morepagestable() should accept float instead of int
2023-07-26 18:26:20 -03:00
Kamil Tekiela
b02e876833 Pdf::morepagestable() should accept float instead of int
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-26 21:28:23 +01:00
Maurício Meneghini Fauth
76d035ae57
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-26 16:58:15 -03:00
Maurício Meneghini Fauth
2b09971846
Merge pull request #18570 from kamil-tekiela/getRelationsAndStatus
Refactor Relation::getRelationsAndStatus()
2023-07-26 16:16:57 -03:00