Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints
...
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-02 01:32:12 -03:00
Maurício Meneghini Fauth
646ba27794
Add missing native parameter type declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-01 17:51:29 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
b07f039578
Add missing native return types
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:22:24 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
...
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
38f6b238db
Move public files to the public directory
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 15:36:31 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type
...
Since union type are now possible, using union with null makes more
clear that it is a union type.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
8eb1cef07d
Use generic template for ExportRelationSchema::$diagram
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:18:39 -03:00
Maurício Meneghini Fauth
48f671d956
Replace get_class() with ::class constant
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:58:13 -03:00
Maurício Meneghini Fauth
efed55320d
Fix invalid PHP doc blocks
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:46:35 -03:00
Maurício Meneghini Fauth
b0bc4f460e
Use null safe object operator where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:21:56 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 17:03:05 -03:00
Maurício Meneghini Fauth
5cbb878dda
Replace Heredoc strings with Nowdoc strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 16:46:21 -03:00
Maurício Meneghini Fauth
41e9b64418
Remove exception variable from non-capturing catch
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-19 18:55:35 -03:00
Maurício Meneghini Fauth
f5ed30d772
Upgrade to phpmyadmin/coding-standard 4.0
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-19 18:37:56 -03:00
Maurício Meneghini Fauth
c0941401c1
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-11 14:26:19 -03:00
Maurício Meneghini Fauth
2653b2942b
Merge branch 'QA_5_1' into QA_5_2
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-11 13:02:15 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
William Desportes
dd0f88f6d9
Forbid phpcs to sniff files that are in the .git folder
...
Example: `.git/refs/remotes/kamil-tekiela/Refactor-Menu.php`
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-03-05 19:34:21 +01:00
Maurício Meneghini Fauth
f99e019112
Update Psalm baseline
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-26 09:47:47 -03:00
Maurício Meneghini Fauth
f61d3183fb
Inline some phpcs ignores and remove deprecated annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-12 11:59:39 -03:00
Maurício Meneghini Fauth
90778eecf7
Upgrade phpmyadmin/coding-standard to 3.0.0
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-19 02:20:46 -03:00
William Desportes
147ada050f
Ignore language_stats.inc.php from phpcs
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-19 00:45:51 +01:00
William Desportes
fda5195be7
Fix logs system and temp dir for tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-09 02:01:23 +01:00
William Desportes
4d8de02871
Remove rules broken or included in the new coding standard
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-16 19:36:52 +01:00
Maurício Meneghini Fauth
8687d5990f
Ignore all cache files for PHPCS
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-22 20:57:59 -03:00
William Desportes
fa457e6b49
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-15 15:46:44 +02:00
William Desportes
93c21ed7f1
Fix #14644 - Use Doctum instead of Sami
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-15 15:11:51 +02:00
William Desportes
ce83b34459
Fixes #16278 - Remove phpcs underscore rule
...
Closes : #16293
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:50:08 +02:00
Maurício Meneghini Fauth
00d35b6543
Reduce severity instead of excluding phpcs rules
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 23:52:40 -03:00
Maurício Meneghini Fauth
2358b9c4f9
Fix missing property type hints
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
7f3d9d29db
[pick] ( 50c9aa6017) Do not use a temp file for PHPCS cache file
...
Ref: 50c9aa6017
Note: I cherry-picked this commit because adding only the .gitignore is useless
[ci skip]
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-15 14:13:29 +02:00
Maurício Meneghini Fauth
50c9aa6017
Do use a temp file for PHPCS cache file
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-13 14:48:00 -03:00
William Desportes
b0021bf84d
Fixes : #16149 - Remove underscore prefix from all method names
...
Ref: #16159
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:21:24 +02:00
Maurício Meneghini Fauth
e29f892d62
Use consts to select the CodeGen handler format
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:36:32 -03:00
Maurício Meneghini Fauth
e2eac49ad2
Use closures to call private methods as callback
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
Maurício Meneghini Fauth
58eee2e371
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
199e3d9813
Fix coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:08:55 -03:00
Maurício Meneghini Fauth
2c5f80fc46
Upgrade phpmyadmin/coding-standard to v2
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 20:32:00 -03:00
Maurício Meneghini Fauth
94955f187a
Fix function call signatures indentation
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
d654b4fec7
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 12:17:34 +02:00
William Desportes
52b6930fac
Exclude 5.1 libraries/cache from phpcs analysis
...
Ref: 1481534ff1
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 12:15:35 +02:00
William Desportes
01f21e0fdf
Add new cache directory
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-28 10:38:11 +01:00
William Desportes
34b9278265
Exclude twig-templates temporary folder and *.twig files from phpcs
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-24 23:00:46 +01:00
Maurício Meneghini Fauth
3658e6d3d1
Ignore missing return in function comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:13:06 -03:00