Commit Graph

124 Commits

Author SHA1 Message Date
Kamil Tekiela
47959814a4 Remove globals charset_connection & collation_connection
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-04 21:32:05 +01:00
Maurício Meneghini Fauth
eff6872c83
Fix PHPUnit 10.3 soft deprecations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-04 13:58:06 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-07 11:44:01 -03:00
Maurício Meneghini Fauth
4331caa676
Add Server class as a param for DatabaseInterface::postConnect()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-07 02:26:34 -03:00
Maximilian Krög
abf49ce9d4
Bettery types for DbiDummy / DummyResult
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-07 21:47:07 +02:00
Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-02 01:32:12 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Maurício Meneghini Fauth
5c5e8c2de1
Replace $GLOBALS['cfg']['MysqlMinVersion'] in Common class
Replaces with PhpMyAdmin\Config\Settings::$mysqlMinVersion access.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-02 17:29:54 -03:00
Maurício Meneghini Fauth
f9c8035768
Add native parameter types to test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-27 01:54:03 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Kamil Tekiela
164bf08f4c Move getColumnMapFromSql() to SystemDatabase
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-15 12:41:47 +00:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-14 12:42:16 -03:00
Maurício Meneghini Fauth
4129bfe23e
Create Dbal/Statement interface
Wraps mysqli_stmt class with the Dbal\MysqliStatement class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-20 00:36:01 -03:00
Maurício Meneghini Fauth
41dec1effc
Extract connection type constants to the Connection class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-17 02:21:27 -03:00
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
3c26a938cb
Add better type inference for DatabaseInterface::$links
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-18 21:36:38 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-13 21:08:00 -03:00
William Desportes
3c0f662ea6
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:32:16 +02:00
William Desportes
2d3bfe3fb4
Fix casing of isMariaDb on DatabaseInterfaceTest class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:30:55 +02:00
William Desportes
fd13e506d0
Fixup tests and DBI after changing setVersion() in DBI
Signed-off-by: William Desportes <williamdes@wdes.fr>

See: cac09436c9
2022-10-13 20:28:32 +02:00
William Desportes
6da193304f
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-13 20:13:48 +02:00
Mo Sureerat
97158c754b Add test case for DatabaseInterface
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-12 22:40:57 +07:00
Mo Sureerat
4d52baf700 Add test case for Types & DatabaseInterface
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-12 21:41:48 +07:00
Mo Sureerat
9ff395e888 Fix type
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 13:40:20 +07:00
Mo Sureerat
81bdecf713 Improve test
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 13:21:35 +07:00
Mo Sureerat
cac09436c9 Rewrite method to set database info
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 13:01:19 +07:00
Mo Sureerat
bd8a9efce0 Add more test for coverage
Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-11 02:44:34 +07:00
Maurício Meneghini Fauth
a3228b8d54
Add unit test for the DatabaseInterface::prepare method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-02 21:06:26 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
da7c7a84e1
Refactor the DatabaseInterfaceTest test class
Inline the dbi and dummyDbi properties.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-20 21:38:11 -03:00
Maurício Meneghini Fauth
7b1dd0ea6c
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-12 11:42:17 -03:00
William Desportes
895b089e96
Ref #17287 - Add a test for getDatabasesFull and data sorting
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-02-11 22:26:03 +01:00
Maurício Meneghini Fauth
76bb42957e
Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-26 15:02:39 -03:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:31:27 +00:00
Maurício Meneghini Fauth
995ec44d13
Move DatabaseInterface::initRelationParamsCache method to Relation class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
William Desportes
828d8e1de4
Merge branch 'QA_5_1'
Also fixed tests from previous merge: 2d307ed062

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-31 00:46:37 +02:00
William Desportes
2d307ed062
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-31 00:18:17 +02:00
William Desportes
2b177839bf
Fix tests after dc5cf4766b
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 04:08:11 +02:00
William Desportes
b0ec0fd112
Fix #16906 - Replace table names with the configuration ones while creating the storage tables
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 03:55:58 +02:00
William Desportes
a35553831b
Fix failing tests after last change
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-24 02:01:05 +02:00
William Desportes
2c28a715b4
Add methods to DbiDummy and AbstractTestCase to control changing databases
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-24 02:01:00 +02:00
William Desportes
517479f846
Fix failing test depending on variable order in the array
Seed: 1628944337

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-14 14:45:01 +02:00
William Desportes
880043961e
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-11 02:53:56 +02:00
William Desportes
b98a3a7589
Ref #17039 - Fix testPostConnectControl test
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-11 02:40:17 +02:00