* Remove $GLOBALS['PMA_PHP_SELF'] Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Remove $GLOBALS['PMA_PHP_SELF'] from tests Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Moved cleanupPathInfo to Routing Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Remove parse_url from getRootPath Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Update baselines Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Remove invalid tests Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Fix trailing slash in path Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> --------- Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
135 lines
4.3 KiB
PHP
135 lines
4.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace PhpMyAdmin\Tests;
|
|
|
|
use FastRoute\Dispatcher;
|
|
use PhpMyAdmin\Controllers\HomeController;
|
|
use PhpMyAdmin\Routing;
|
|
|
|
use function copy;
|
|
use function unlink;
|
|
|
|
use const CACHE_DIR;
|
|
use const TEST_PATH;
|
|
|
|
/** @covers \PhpMyAdmin\Routing */
|
|
class RoutingTest extends AbstractTestCase
|
|
{
|
|
/**
|
|
* Test for Routing::getDispatcher
|
|
*/
|
|
public function testGetDispatcher(): void
|
|
{
|
|
$expected = [Dispatcher::FOUND, HomeController::class, []];
|
|
$cacheFilename = CACHE_DIR . 'routes.cache.php';
|
|
$validCacheFilename = TEST_PATH . 'test/test_data/routes/routes-valid.cache.txt';
|
|
$invalidCacheFilename = TEST_PATH . 'test/test_data/routes/routes-invalid.cache.txt';
|
|
$GLOBALS['cfg']['environment'] = null;
|
|
|
|
$this->assertDirectoryIsWritable(CACHE_DIR);
|
|
|
|
// Valid cache file.
|
|
$this->assertTrue(copy($validCacheFilename, $cacheFilename));
|
|
$dispatcher = Routing::getDispatcher();
|
|
$this->assertInstanceOf(Dispatcher::class, $dispatcher);
|
|
$this->assertSame($expected, $dispatcher->dispatch('GET', '/'));
|
|
$this->assertFileEquals($validCacheFilename, $cacheFilename);
|
|
|
|
// Invalid cache file.
|
|
$this->assertTrue(copy($invalidCacheFilename, $cacheFilename));
|
|
$dispatcher = Routing::getDispatcher();
|
|
$this->assertInstanceOf(Dispatcher::class, $dispatcher);
|
|
$this->assertSame($expected, $dispatcher->dispatch('GET', '/'));
|
|
$this->assertFileNotEquals($invalidCacheFilename, $cacheFilename);
|
|
|
|
// Create new cache file.
|
|
$this->assertTrue(unlink($cacheFilename));
|
|
|
|
$this->assertFileDoesNotExist($cacheFilename);
|
|
|
|
$dispatcher = Routing::getDispatcher();
|
|
$this->assertInstanceOf(Dispatcher::class, $dispatcher);
|
|
$this->assertSame($expected, $dispatcher->dispatch('GET', '/'));
|
|
$this->assertFileExists($cacheFilename);
|
|
|
|
// Without a cache file.
|
|
$GLOBALS['cfg']['environment'] = 'development';
|
|
$dispatcher = Routing::getDispatcher();
|
|
$this->assertInstanceOf(Dispatcher::class, $dispatcher);
|
|
$this->assertSame($expected, $dispatcher->dispatch('GET', '/'));
|
|
}
|
|
|
|
/**
|
|
* @param string $php_self The PHP_SELF value
|
|
* @param string $request The REQUEST_URI value
|
|
* @param string $path_info The PATH_INFO value
|
|
* @param string $expected Expected result
|
|
*
|
|
* @dataProvider providerForTestCleanupPathInfo
|
|
*/
|
|
public function testCleanupPathInfo(string $php_self, string $request, string $path_info, string $expected): void
|
|
{
|
|
$_SERVER['PHP_SELF'] = $php_self;
|
|
$_SERVER['REQUEST_URI'] = $request;
|
|
$_SERVER['PATH_INFO'] = $path_info;
|
|
$actual = Routing::getCleanPathInfo();
|
|
$this->assertEquals($expected, $actual);
|
|
}
|
|
|
|
public static function providerForTestCleanupPathInfo(): array
|
|
{
|
|
return [
|
|
[
|
|
'/phpmyadmin/index.php/; cookieinj=value/',
|
|
'/phpmyadmin/index.php/;%20cookieinj=value///',
|
|
'/; cookieinj=value/',
|
|
'/phpmyadmin/index.php',
|
|
],
|
|
[
|
|
'',
|
|
'/phpmyadmin/index.php/;%20cookieinj=value///',
|
|
'/; cookieinj=value/',
|
|
'/phpmyadmin/index.php',
|
|
],
|
|
[
|
|
'',
|
|
'//example.com/../phpmyadmin/index.php',
|
|
'',
|
|
'/phpmyadmin/index.php',
|
|
],
|
|
[
|
|
'',
|
|
'//example.com/../../.././phpmyadmin/index.php',
|
|
'',
|
|
'/phpmyadmin/index.php',
|
|
],
|
|
[
|
|
'',
|
|
'/page.php/malicouspathinfo?malicouspathinfo',
|
|
'malicouspathinfo',
|
|
'/page.php',
|
|
],
|
|
[
|
|
'/phpmyadmin/./index.php',
|
|
'/phpmyadmin/./index.php',
|
|
'',
|
|
'/phpmyadmin/index.php',
|
|
],
|
|
[
|
|
'/phpmyadmin/index.php',
|
|
'/phpmyadmin/index.php',
|
|
'',
|
|
'/phpmyadmin/index.php',
|
|
],
|
|
[
|
|
'',
|
|
'/phpmyadmin/index.php',
|
|
'',
|
|
'/phpmyadmin/index.php',
|
|
],
|
|
];
|
|
}
|
|
}
|