gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
f7f8722e1f
phpmyadmin/libraries/classes/Controllers
History
Kamil Tekiela f7f8722e1f
Refactor insert edit (#17684) 
This is a major redesign of the code that handles these four actions: in-place edit(AJAX), edit of multiple rows, copying of rows, and insertion of new rows. The goal is to make the code easier to read and more understandable.

    I introduced a new DTO for better readability.
    Some of the methods were made private to the model
    The controller has access to two methods for getting the value for INSERT and for UPDATE
    Unfortunately, I have introduced method envy on EditField, but I do not want to move the functionality away from InsertEdit.php
    Unit tests have not improved in readability but I added helpful comments explaining what we are testing. There's probably a way to improve it too.

I will probably merge all commits once I decide it's ready for review.


Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-22 22:39:53 -03:00
..
Config Add type declarations to the controllers contructors 2021-09-11 17:32:22 -03:00
Database Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
Export Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
Import Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
Normalization Extract normalization's partial dependencies action 2022-08-02 22:49:07 -03:00
Preferences Move Routing::getCurrentRoute to ServerRequest 2022-06-06 23:36:57 -03:00
Server Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
Setup Remove PMA_IS_WINDOWS constant 2022-04-24 20:37:55 -03:00
Sql Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
Table Refactor insert edit (#17684) 2022-08-22 22:39:53 -03:00
Transformation Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
View Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
AbstractController.php Add method to AbstractController to send error messages 2022-03-20 16:39:33 -03:00
BrowseForeignersController.php Remove ResponseRenderer::getFooter method 2022-04-09 12:32:14 -03:00
ChangeLogController.php Extract url.php entry point into a route 2022-08-06 15:02:49 -03:00
CheckRelationsController.php Replace global keyword with $GLOBALS 2022-03-07 17:31:11 -03:00
CollationConnectionController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ColumnController.php Add type declarations to the controllers contructors 2021-09-11 17:32:22 -03:00
DatabaseController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ErrorReportController.php Remove ResponseRenderer::getFooter method 2022-04-09 12:32:14 -03:00
GisDataEditorController.php Fix possible undefined globals 2022-03-10 18:05:21 -03:00
GitInfoController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
HomeController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
JavaScriptMessagesController.php Assign Messages global var to the window object 2022-07-02 11:23:07 -03:00
LicenseController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
LintController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
LogoutController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
NavigationController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
PhpInfoController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
RecentTablesListController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
SchemaExportController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
TableController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ThemesController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ThemeSetController.php Refactor ThemeSetController class 2022-04-01 01:13:39 -03:00
UserPasswordController.php Move Routing::getCurrentRoute to ServerRequest 2022-06-06 23:36:57 -03:00
VersionCheckController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00