phpmyadmin/libraries/classes/Controllers/Table
Kamil Tekiela f7f8722e1f
Refactor insert edit (#17684)
This is a major redesign of the code that handles these four actions: in-place edit(AJAX), edit of multiple rows, copying of rows, and insertion of new rows. The goal is to make the code easier to read and more understandable.

    I introduced a new DTO for better readability.
    Some of the methods were made private to the model
    The controller has access to two methods for getting the value for INSERT and for UPDATE
    Unfortunately, I have introduced method envy on EditField, but I do not want to move the functionality away from InsertEdit.php
    Unit tests have not improved in readability but I added helpful comments explaining what we are testing. There's probably a way to improve it too.

I will probably merge all commits once I decide it's ready for review.


Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-22 22:39:53 -03:00
..
Maintenance Add exceptions for invalid identifier names 2022-03-19 17:35:35 -03:00
Partition Add basic tests for Controllers\Table\Partition classes 2022-07-27 15:29:02 -03:00
Structure Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
AddFieldController.php Introduce the ServerRequest object to AddFieldController 2022-05-04 15:55:22 -03:00
ChangeController.php Introduce the ServerRequest object to ChangeController 2022-06-08 19:12:19 -03:00
ChangeRowsController.php Introduce the ServerRequest object to ChangeController 2022-06-08 19:12:19 -03:00
ChartController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
CreateController.php Fix table creation 2022-08-17 20:31:51 +01:00
DeleteConfirmController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
DeleteRowsController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
DropColumnConfirmationController.php Add method to AbstractController to send error messages 2022-03-20 16:39:33 -03:00
DropColumnController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ExportController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ExportRowsController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
FindReplaceController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
GetFieldController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
GisVisualizationController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ImportController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
IndexesController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
IndexRenameController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
OperationsController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
PrivilegesController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
RecentFavoriteController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
RelationController.php Move Routing::getCurrentRoute to ServerRequest 2022-06-06 23:36:57 -03:00
ReplaceController.php Refactor insert edit (#17684) 2022-08-22 22:39:53 -03:00
SearchController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
SqlController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
StructureController.php Move Routing::getCurrentRoute to ServerRequest 2022-06-06 23:36:57 -03:00
TrackingController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
TriggersController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00
ZoomSearchController.php Add ServerRequest parameter to all controllers 2022-07-28 01:00:08 -03:00