William Desportes
4d16355fba
Adjust check release excludes script for public/ folder
...
Ref: #18145 (ec31cbebc6
2023-05-29 13:29:40 +02:00
William Desportes
44ba9a5d22
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 13:16:36 +02:00
William Desportes
c4c0c8c834
Bump laminas/laminas-diactoros CI PHP requirement to PHP 8.0
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 13:12:18 +02:00
William Desportes
21cf996096
Merge #18462 - Code improvement: NullableCompareToNullRector
...
Pull-request: #18462
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 13:05:51 +02:00
William Desportes
62a44a78bb
Merge #18465 - Use array shape for getPaths
...
Pull-request: #18465
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 13:04:34 +02:00
William Desportes
3e644647e8
Fix mock value bug in phpunit, bump phpunit 8.5
...
This did happen to me in Ubuntu while packaging, until now I did not understand it correctly.
It's a phpunit bug for sure, patched in 8.5.16.
Most probably due to https://github.com/sebastianbergmann/phpunit/pull/4678
```
1) PhpMyAdmin\Tests\TableTest::testDuplicateInfo
Invalid argument supplied for foreach()
libraries/classes/Table.php:944
test/classes/TableTest.php:955
phpvfscomposer://vendor/phpunit/phpunit/phpunit:60
```
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 13:01:09 +02:00
Kamil Tekiela
a72ec07b68
Use array shape for getPaths
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-29 11:43:43 +01:00
William Desportes
2db38cbe03
Bump phpmyadmin/twig-i18n-extension for PHP 8 support
...
Run: `php7.2 /bin/composer update --prefer-lowest`
PHP message: PHP Deprecated: Optional parameter $context declared before required parameter $notes is implicitly treated as a required parameter in vendor/phpmyadmin/twig-i18n-extension/src/Node/TransNode.php on line 65
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 12:29:09 +02:00
William Desportes
18f5ab26fa
Bump the version of web-auth/webauthn-lib
...
Run: `php7.2 /bin/composer update --prefer-lowest`
and `php7.2 ./vendor/bin/phpunit --filter=webauth`
```
1) PhpMyAdmin\Tests\WebAuthn\WebauthnLibServerTest::testGetCredentialCreationOptions
ArgumentCountError: Too few arguments to function Webauthn\Server::__construct(), 2 passed in libraries/classes/WebAuthn/WebauthnLibServer.php on line 45 and exactly 3 expected
PhpMyAdmin\Tests\WebAuthn\WebauthnLibServerTest::testGetCredentialRequestOptions
ArgumentCountError: Too few arguments to function Webauthn\Server::__construct(), 2 passed in libraries/classes/WebAuthn/WebauthnLibServer.php on line 83 and exactly 3 expected
```
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 12:19:57 +02:00
William Desportes
4504fe0866
Fix a testing warning
...
1) Warning
Test method "testOrSkip" in test class "PhpMyAdmin\Tests\Http\Factory\ServerRequestFactoryTest" is not public.
phpvfscomposer:///vendor/phpunit/phpunit/phpunit:60
vendor/bin/phpunit:118
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 12:11:58 +02:00
William Desportes
eec0f60b84
Update baselines
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 12:06:26 +02:00
William Desportes
30274190f8
Fix test-php-psr7-implementations CI
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 12:05:23 +02:00
William Desportes
34922bace5
Update create-release.sh
...
Ref: https://github.com/DASPRiD/Enum/pull/14
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 11:37:58 +02:00
William Desportes
98cd2ab1de
Fix the workflow for PSR-7 libraries
...
Ref: 3b4b4e287a
2023-05-29 11:25:38 +02:00
William Desportes
9a68412f4d
Update ChangeLog for 54471c7cd8
...
Ref: 54471c7cd8
2023-05-29 11:23:11 +02:00
William Desportes
54471c7cd8
Require slim/psr7 1.4.1 for CVE-2023-30536 - GHSA-q2qj-628g-vhfw
...
Ref: https://github.com/slimphp/Slim-Psr7/pull/286
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 11:21:58 +02:00
William Desportes
a9cd68b87d
Revert "Replace slim/psr7 by nyholm/psr7"
...
This reverts commit 4a965c6d15
2023-05-29 11:21:53 +02:00
William Desportes
95866856f9
Merge #18452 - Prefill the field field_default_value on Central Columns
...
Pull-request: #18452
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-05-29 11:13:31 +02:00
Maurício Meneghini Fauth
920751a77a
Create the TriggerName value object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-28 15:46:59 -03:00
phpMyAdmin bot
3949e5b41a
Update po files
...
[ci skip]
Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2023-05-28 00:19:35 +00:00
Kamil Tekiela
f4f2f93b1c
NullableCompareToNullRector
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-27 21:58:12 +01:00
Maurício Meneghini Fauth
1582b69591
Change Trigger::$table type to use TableName object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-27 16:17:21 -03:00
Maurício Meneghini Fauth
a2ed355faf
Add Timing enum for triggers action timing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-27 15:58:29 -03:00
Maurício Meneghini Fauth
7cdbfc2eaf
Add Event enum for trigger events
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-27 15:36:26 -03:00
Maurício Meneghini Fauth
210521bae8
Merge pull request #18456 from MauricioFauth/triggers
...
Refactor the Triggers page
2023-05-27 13:18:40 -03:00
Maurício Meneghini Fauth
ff7fe4bfa0
Extract getTables() method from Triggers::getEditorForm()
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-26 20:29:23 -03:00
Maurício Meneghini Fauth
0d4b85552e
Add Trigger value object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-26 15:38:55 -03:00
Maurício Meneghini Fauth
84c4de778b
Add unit tests for Triggers::getDetails() method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 22:26:16 -03:00
Maurício Meneghini Fauth
5a344966a9
Move trigger row foreach loop into the list.twig template
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 16:03:45 -03:00
Maurício Meneghini Fauth
81e988aac8
Inline Triggers::main() into the Triggers\IndexController
...
The main() method is handling the request/response, so it's better to
move this code to the controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 15:40:16 -03:00
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers
...
They are equivalent in current form.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
d006f2ae48
Fix blank DB tracking page when using control user
...
The control user should not have permission to show tables.
See https://docs.phpmyadmin.net/en/latest/setup.html#manual-configuration
Related to https://github.com/phpmyadmin/phpmyadmin/pull/18259
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-24 22:47:38 -03:00
Maurício Meneghini Fauth
62ec1bcc2c
Merge pull request #18445 from kamil-tekiela/InsertEdit-pt4
...
InsertEdit refactoring - part 4
2023-05-24 21:16:01 -03:00
Maurício Meneghini Fauth
b100c05f84
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-24 18:51:53 -03:00
Kamil Tekiela
0a2512e583
Prefill the field field_default_value
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-24 22:34:20 +01:00
IAndreyI
7943cf86ed
Fix #18314 - dragged row in index form ( #18388 )
...
* fix dragged row in index form
Signed-off-by: Petrichenko Andrey <1993czar@gmail.com>
* correct remarks
Signed-off-by: Petrichenko Andrey <1993czar@gmail.com>
---------
Signed-off-by: Petrichenko Andrey <1993czar@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-24 18:22:49 -03:00
Maurício Meneghini Fauth
6d6f3dc29f
Merge pull request #18449 from kamil-tekiela/Fix-broken-link-button
...
Fix broken link-button
2023-05-24 17:36:32 -03:00
Kamil Tekiela
daa6cb9c12
Fix broken link-button
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-24 21:29:45 +01:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2
...
Replace superglobals with serverrequest in GetFieldController
2023-05-24 15:31:24 -03:00
Maurício Meneghini Fauth
d0e1b3a093
Fix missing params when using Edit inline on SQL message box
...
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/18440
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-23 18:17:16 -03:00
Maurício Meneghini Fauth
1a611a9641
Fix failing Selenium tests
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-23 18:05:17 -03:00
Maurício Meneghini Fauth
d1c6861b2c
Fix some failing Selenium tests
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-23 17:12:01 -03:00
Maurício Meneghini Fauth
9e56194fc0
Fix issue with inline edit with multiple SQL message box
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-23 15:38:18 -03:00
Kamil Tekiela
7838a42a34
Move buildInsertSqlQuery to Generator
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-23 15:31:46 +01:00
Kamil Tekiela
fa826f737a
Implement InsertEditColumn
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-23 15:31:46 +01:00
Kamil Tekiela
90c0dc3b30
Remove unused params in IO plugins
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-23 15:31:46 +01:00
Kamil Tekiela
919bf36460
Move getColumnTitle() out of $column
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-23 15:31:46 +01:00
Kamil Tekiela
719bc91797
$column['values'] is never set anywhere
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-23 15:31:46 +01:00
Maurício Meneghini Fauth
30ff7d4b6a
Merge pull request #18434 from kamil-tekiela/InsertEdit-pt-3
...
InsertEdit refactoring - part 3
2023-05-23 11:02:09 -03:00
Kamil Tekiela
37473d1a36
Update psalm-baseline.xml
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-22 23:47:14 +01:00
