Commit Graph

118810 Commits

Author SHA1 Message Date
William Desportes
4de5bcb2a7
Support selenium-standalone mode and use docker
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
28dc408813
Update and fix the test/README
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
e2de21292a
Fix more queries
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
e95e055af0
Fix ImportTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
b062eeff33
Fix EventsTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
c942d31eae
Fix ProceduresTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
26b493cdf0
Fix StructureTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
9b1effdee7
Fix TriggersTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
0af6e5f022
Fix OperationsTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
cefe239d77
Fix EventsTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
95089fbe49
Fix CreateDropDatabaseTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
William Desportes
c91044c401
Drop all the mysqli config to execute SQL statements with the sql query tab
Signed-off-by: William Desportes <williamdes@wdes.fr>

Test base fixes

Signed-off-by: William Desportes <williamdes@wdes.fr>

Drop mysqli


Improve and fix dbQuery on selenium tests

Signed-off-by: William Desportes <williamdes@wdes.fr>

Improve TestBase and fix all reported errors

Signed-off-by: William Desportes <williamdes@wdes.fr>

Remove usage of globals in all the selenium test suite

Signed-off-by: William Desportes <williamdes@wdes.fr>

Improve the process on the SQL window

Signed-off-by: William Desportes <williamdes@wdes.fr>

Update baselines

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-10 01:27:22 +02:00
Maurício Meneghini Fauth
000161d9e6
Merge pull request #16182 from mauriciofauth/browserslist
Add list of supported browsers
2020-06-09 16:53:54 -03:00
Maurício Meneghini Fauth
f43537e460 Add eslint-plugin-compat package
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-09 16:32:18 -03:00
Maurício Meneghini Fauth
044b6dca2b Add list of supported browsers
Uses Browserslist format.
Same list used by Bootstrap v4.4.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-09 15:58:55 -03:00
Maurício Meneghini Fauth
a4644916f6
Merge pull request #16181 from mauriciofauth/button-formaction
Use button formaction attribute for table structure bulk links
2020-06-09 15:41:52 -03:00
Maurício Meneghini Fauth
5d400b73fd Use formaction attr for table structure bulk links
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-09 15:06:00 -03:00
William Desportes
5234f6b3d4
Fix a coding standard issue for #16180
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-09 13:46:25 +02:00
William Desportes
655389292d
Fix #16180 - [5.1-dev, security] XSS, unescaped route displayed on 404 page
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-09 13:45:14 +02:00
Maurício Meneghini Fauth
41d401b95e Extract save action from table structure index method
Closes #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 19:57:28 -03:00
William Desportes
d9a8e22cb9
Upgrade to phpstan 0.12.27
Ref: https://github.com/phpstan/phpstan/issues/3402

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-08 23:33:55 +02:00
Maurício Meneghini Fauth
2529824c23 Extract change column action from table structure index method
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 18:20:48 -03:00
William Desportes
1c00db0dfd
Merge #16165 - fix the permission checking avoid logic
Ref: ffc9a28eaf
Ref: 0138cb471f
Ref: f4582e083e

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-08 22:13:49 +02:00
William Desportes
d4dff2b919
Extract the CSP header logic into a function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-08 22:05:39 +02:00
Maurício Meneghini Fauth
78ff0d0c63 Use PHPStan's new autoloading configuration setup
PHPStan version 0.12.26

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 16:27:56 -03:00
Petr Duda
2bda0e7138
Translated using Weblate (Czech)
Currently translated at 99.3% (3334 of 3355 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/cs/
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-06-08 13:46:16 +02:00
William Desportes
5d933e03b9
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:40:25 +02:00
William Desportes
da495f3eb8
Add a ChangeLog entry for #16157
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:30:08 +02:00
William Desportes
1eb7c00c1c
Fix #16157 - relations of tables having spaces or special chars where not showing in the Designer
We where comparing encoded strings with non encoded ones, that could not work.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:29:37 +02:00
William Desportes
d06ec742e3
Fix an "Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek()"
Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek(): Argument #2 ($offset) must be of type int, string given, called in libraries/classes/Navigation/Nodes/NodeDatabase.php on line 488 and defined in libraries/classes/DatabaseInterface.php:2724"

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:06:40 +02:00
William Desportes
64423efc5f
Add a ChangeLog entry for a5e8cf8553
Ref: a5e8cf8553

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 22:38:45 +02:00
William Desportes
a5e8cf8553
Fix copy table to another database, the select can be an input when the DB count is > $cfg['MaxDbList']
See: Operations::getHtmlForCopytable
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 22:33:05 +02:00
William Desportes
fd775cb9f9
Split some code from Privileges::updatePrivileges into Privileges::generateQueriesForUpdatePrivileges
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 19:23:46 +02:00
William Desportes
42e5ccda77
Improve Privileges::wildcardEscapeForGrant
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:58:06 +02:00
William Desportes
076d7b1a7f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:27:18 +02:00
William Desportes
8f61348781
Add a ChangeLog entry for #16166
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:10:43 +02:00
William Desportes
5164bea16a
Fix #16166 - Make the alter user privileges MySQL 8.0.11+ compatible
Ref: #14217
Ref: #14788

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:08:50 +02:00
William Desportes
9b5240f29e
Add a ChangeLog entry for fb2d11d6a
Ref: fb2d11d6ae

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 16:52:04 +02:00
William Desportes
fb2d11d6ae
Fixed editing a failed query from the error message
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 16:50:44 +02:00
William Desportes
c05387f7d3
Improve retry to connect button style
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 16:06:50 +02:00
Maurício Meneghini Fauth
5df2c41d67 Extract add-key action from table structure index method
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-06 19:35:52 -03:00
Gemorroj
ecdf1ccb32
Avoid check permissions on windows 2020-06-07 00:50:26 +03:00
Maurício Meneghini Fauth
4446963b5a Extract partitioning actions from index method
Extracts from Table/StructureController::index method.

Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-06 17:20:10 -03:00
Maurício Meneghini Fauth
887f531a4d Use Expression[] in Util::getUniqueCondition
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-05 16:06:55 -03:00
Maurício Meneghini Fauth
9d18234581 Refactor Util::getUniqueCondition method
Passes the Statement instance directly instead of the
$analyzed_sql_results array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-05 13:49:44 -03:00
William Desportes
573606067c
Update psalm baseline after 055a9bf3bc
Ref: 055a9bf3bc

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-05 14:06:23 +02:00
William Desportes
055a9bf3bc
Be sure to cast the result and not a possibly undefined index that would send a notice
Ref: 490d731d6c

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-05 14:03:13 +02:00
William Desportes
06df214332
Update baselines
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 18:23:17 +02:00
William Desportes
c2b0377618
Fix the clear filter icon not well aligned on pmahomme theme
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 18:19:49 +02:00
William Desportes
4820175b8a
Fix php error when browsing the designer
The condition was not right, shorten to check only table

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 16:03:04 +02:00