Maurício Meneghini Fauth
6eb5253ef6
Merge pull request #19049 from kamil-tekiela/Fix-impossible-condition-from-#18630
...
Fix impossible condition from #18630
2024-03-13 18:33:40 -03:00
Maurício Meneghini Fauth
af24b291c4
Merge pull request #19048 from kamil-tekiela/Refactor-Transformation-plugin-instantiation
...
Refactor transformation plugin instantiation
2024-03-13 16:48:22 -03:00
Maurício Meneghini Fauth
945efefe99
Merge pull request #19047 from kamil-tekiela/Refactor-import-7
...
Add AnalysedColumn DTO
2024-03-13 15:43:24 -03:00
Salvador Domingues
2016c81409
Translated using Weblate (Portuguese)
...
Currently translated at 94.8% (3229 of 3406 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/pt/
Signed-off-by: Salvador Domingues <salvadordomingues@gmail.com>
2024-03-13 19:01:56 +01:00
Kamil Tekiela
f461ee9a7d
Fix impossible condition from #18630
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-13 13:23:20 +01:00
Kamil Tekiela
bec92e7c19
Fix inheritance of TransformationsInterface
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-12 17:15:37 +01:00
Kamil Tekiela
5536e35cd5
Refactor $transformationInfo
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-12 17:15:37 +01:00
Kamil Tekiela
0c7c968104
Refactor Transformation plugin instantiation
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-12 17:15:37 +01:00
Kamil Tekiela
0472660615
Add AnalysedColumn DTO
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-12 01:47:40 +01:00
Kamil Tekiela
93cef1237d
Create DecimalSize ( #19044 )
...
* Remove duplicated comment
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify getDecimalSize
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Create DecimalSize
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Refactor detectSize()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unhelpful docbloc for detectType
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Break too long line
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove dead constants
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-11 21:32:52 -03:00
phpMyAdmin bot
2e52bdd4b2
Update po files
...
[ci skip]
Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2024-03-10 00:19:12 +00:00
Maurício Meneghini Fauth
f380b01d44
Merge pull request #19043 from kamil-tekiela/Update-SA-tools
...
Update SA tools
2024-03-09 17:36:44 -03:00
Maurício Meneghini Fauth
32b1c17747
Merge pull request #19038 from MauricioFauth/services-files-tests
...
Add tests for app/services* files
2024-03-09 17:34:28 -03:00
Kamil Tekiela
cc18b9366d
Fix coding standard
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-09 21:09:35 +01:00
Kamil Tekiela
bdc16107f1
Update SA tools
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-09 21:08:17 +01:00
Maurício Meneghini Fauth
55d922c313
Add tests for app/services* files
...
Fixes error introduced by
https://github.com/phpmyadmin/phpmyadmin/pull/18625 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 17:02:07 -03:00
Maurício Meneghini Fauth
38bd9dda7f
Merge pull request #19042 from MauricioFauth/init-extraction-from-controllers
...
Extracts loadTableInfo method from controller constructors
2024-03-09 17:00:00 -03:00
Maurício Meneghini Fauth
0b07402e21
Extract loadTableInfo() from ZoomSearchController
...
Makes private methods private.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 15:58:40 -03:00
Maurício Meneghini Fauth
decde7f3fb
Remove controller object from table/zoom_search/index template
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 15:52:40 -03:00
Maurício Meneghini Fauth
21fc3a48ed
Extract loadTableInfo() from SearchController constructor
...
Refactors Table\SearchController tests.
Makes private methods private.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 15:25:43 -03:00
Maurício Meneghini Fauth
f6a8b78a96
Remove controller object from table/search/index template
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 14:40:19 -03:00
Maurício Meneghini Fauth
66916f39f7
Remove dead code from Table\SearchController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 14:00:45 -03:00
Maurício Meneghini Fauth
861dd4e8b8
Extract loadTableInfo() from FindReplaceController constructor
...
Refactors FindReplaceController tests.
Makes private methods private.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-09 13:40:05 -03:00
Kamil Tekiela
c8654bfdb5
Extract 2 methods from Import ( #19036 )
...
* Fix type hint in getLocalFiles()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unset($params);
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Extract getHtmlListForAllTables() & getSuccessMessage()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-08 17:45:59 -03:00
Maurício Meneghini Fauth
ac77797d89
Merge pull request #19035 from kamil-tekiela/Refactor-import-4
...
Split $createDb from buildSql() method
2024-03-08 15:46:33 -03:00
Kamil Tekiela
583db25d64
Split $createDb from buildSql
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-08 19:09:52 +01:00
Salvador Domingues
9308f89de9
Translated using Weblate (Portuguese)
...
Currently translated at 94.8% (3229 of 3406 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/pt/
Signed-off-by: Salvador Domingues <salvadordomingues@gmail.com>
2024-03-08 09:41:56 +01:00
Nova
9bc956fbd1
Translated using Weblate (English (United Kingdom))
...
Currently translated at 97.5% (3324 of 3406 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/en_GB/
Signed-off-by: Nova <luna.bowley@gmail.com>
2024-03-08 09:41:55 +01:00
Maurício Meneghini Fauth
87e0c21303
Merge pull request #19029 from kamil-tekiela/Refactor-import-3
...
Use enum instead of constants in Import
2024-03-07 14:46:00 -03:00
Kamil Tekiela
eb9be36606
Use enum instead of constants
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-07 18:18:24 +01:00
Salvador Domingues
def925efe1
Translated using Weblate (Portuguese)
...
Currently translated at 94.8% (3229 of 3406 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/pt/
Signed-off-by: Salvador Domingues <salvadordomingues@gmail.com>
2024-03-07 05:09:42 +01:00
Nabin Ghimire
b846b89ef7
Translated using Weblate (Nepali)
...
Currently translated at 1.9% (66 of 3406 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ne/
Signed-off-by: Nabin Ghimire <nnabinn@hotmail.com>
2024-03-07 05:09:39 +01:00
Kristijan \"Fremen\" Velkovski
746a188057
Translated using Weblate (Macedonian)
...
Currently translated at 27.5% (939 of 3406 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>
2024-03-06 05:39:15 +01:00
Kamil Tekiela
60fb1a8504
Use array_fill
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-05 22:45:13 +01:00
Maurício Meneghini Fauth
1eefe72f98
Merge pull request #19025 from kamil-tekiela/intval
...
Replace function casts with normal casts
2024-03-04 15:18:26 -03:00
Kamil Tekiela
54b5464ec2
Replace function casts with normal casts
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-03 15:07:57 +01:00
Maurício Meneghini Fauth
856d316332
Merge pull request #18812 from kamyweb/role_based_auth
...
Add role based auth for MySQL 8.x and compatibles
2024-03-03 01:48:58 -03:00
Luca Camillo
457192102f
Add role based auth for MySQL 8.x and compatibles
...
add role based auth for mysql 8.x or compatible like mariadb/aws rds aurora mysql
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
better cache management
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
null for unsupported
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
add caching and check if role is supported based on server version
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
checking isRoleSupported before query
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
implement tests for getCurrentRolesAndHost / getCurrentRoles functions
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
use different name for host of role and keep value inside session cache
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
fix role checks on mariadb
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
Simplify code
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
ignore NONE as result of CURRENT_ROLE()
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
fix comments
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
2024-03-03 01:38:01 -03:00
Maurício Meneghini Fauth
a82c7fcb6f
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-03 00:46:10 -03:00
phpMyAdmin bot
713ae87e85
Update po files
...
[ci skip]
Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2024-03-03 00:18:43 +00:00
Luca Camillo
78335aac87
Add role based auth for MySQL 8.x and compatibles ( #18814 )
...
* add role based auth for mysql 8.x or compatible like mariadb/aws rds aurora mysql
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
* Using cache and check server version
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
* implement tests for getCurrentRolesAndHost / getCurrentRoles functions
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
* fix role checks on mariadb
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
* Simplify code + ignore NONE as result of CURRENT_ROLE()
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
* Fix tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Fixes #18782
---------
Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-02 19:31:03 -03:00
Maurício Meneghini Fauth
ba29aa6e82
Merge pull request #19022 from MauricioFauth/navigation-node-name-issue
...
Fix case where tables from wrong db is loaded in navigation
2024-02-29 17:42:23 -03:00
Maurício Meneghini Fauth
0048963013
Fix case where tables from wrong db is loaded in navigation
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-29 16:23:30 -03:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools ( #19013 )
...
* Drop array keys from lists
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Import UrlTest
When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Drop redundant return [];
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix object access checks
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use strict comparison
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Int keys should be specified as integers
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use empty string check instead of strlen
Potential null deprecations are replaced with loose condition.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use stripos instead of *substr
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify substr's 3rd param
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unnecessary defaults
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace isZeroBasedArray with array_is_list
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify texEscape()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify exportZeroBasedArray()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace for loop with array_diff
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace for with foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove nullable param in backquoteCompat
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use null-coalescing operator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Inline $result variable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Turn $event into a constant
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Move selectDb outside the loop
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix code style order of operation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unnecessary isset argument
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove line break
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use foreach instead of for
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
e68e814e57
Update PHP dependencies
...
- Upgrading composer/ca-bundle (1.4.0 => 1.4.1)
- Upgrading phpdocumentor/type-resolver (1.8.1 => 1.8.2)
- Upgrading phpstan/phpdoc-parser (1.25.0 => 1.26.0)
- Upgrading phpstan/phpstan-phpunit (1.3.15 => 1.3.16)
- Upgrading phpunit/phpunit (10.5.10 => 10.5.11)
- Upgrading roave/security-advisories (dev-latest 1f77ae7 => dev-latest aafb723)
- Upgrading vimeo/psalm (5.22.1 => 5.22.2)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-26 12:17:24 -03:00
Maurício Meneghini Fauth
c84191a568
Merge pull request #19012 from MauricioFauth/unit-tests
...
Add some unit tests
2024-02-26 11:37:27 -03:00
Maurício Meneghini Fauth
cbff3f344e
Add unit tests for UrlRedirector
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-25 15:54:12 -03:00
Maurício Meneghini Fauth
ecafb167ee
Add code coverage for some value objects
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-25 14:40:00 -03:00
Maurício Meneghini Fauth
70425bae12
Add unit test for Session::secure()
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-25 14:10:05 -03:00
phpMyAdmin bot
a5b72495e6
Update po files
...
[ci skip]
Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2024-02-25 00:18:55 +00:00