Commit Graph

118745 Commits

Author SHA1 Message Date
William Desportes
7c50dc71a0
Merge #16159 - Remove underscore prefix from method names
Pull-request: #16159

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:16:10 +02:00
William Desportes
9668731fe6
Fix selenium tests warnings on private test methods after removing _
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:07:11 +02:00
William Desportes
a13e5d1c16
Fix tests documentation after removing _ from private methods
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:01:57 +02:00
William Desportes
3f0b7390e2
Fix documentation after removing _ from private methods
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:56:48 +02:00
William Desportes
707d263531
Fix testSetGetPdf and testSetGetPdfTitle
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:54:45 +02:00
charliewindred
7d792e88f6
Removed underscores from unit test methods
Removed underscore prefixes from unit test method calls.

Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 23:52:32 +02:00
William Desportes
7623fed14a
Fix all found errors and add typehints if possible on NavigationTree class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:50:49 +02:00
William Desportes
62baf0b8ea
Change Node::getChild return to ?Node
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:10:35 +02:00
William Desportes
82d7328d84
Fix failing test NavigationTreeTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 22:55:03 +02:00
William Desportes
f433d5e7bc
Remove a typehint and document the edge case for _fetchValue
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 22:50:51 +02:00
charliewindred
cec8c6f9b3
Updated baselines
Updated baselines after fixing previous errors.

Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 20:09:19 +02:00
charliewindred
195c11d928 Fixed unused private methods in Response.php
Removed missed underscores that caused unused private method errors.

Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 17:42:56 +01:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
William Desportes
434b5ec5b8
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 09:19:19 +02:00
William Desportes
6266583e63
Add some typehints on NavigationTree
Ref: #16158

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 09:18:51 +02:00
Petr Duda
dd7d6534b3
Translated using Weblate (Czech)
Currently translated at 99.8% (3329 of 3334 strings)

[CI skip]

Translation: phpMyAdmin/5.0
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/cs/
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-31 23:41:42 +02:00
William Desportes
c9c659f28f
Merge remote-tracking branch 'Weblate_master/master'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 21:19:19 +02:00
Petr Duda
f249bc9ee3
Translated using Weblate (Czech)
Currently translated at 98.6% (3311 of 3355 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/cs/
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-31 21:16:15 +02:00
William Desportes
e6b89bcaca
Update po files
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 21:14:47 +02:00
William Desportes
4bf5fa696d
Split some code into functions in the ImportCsv class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 21:13:40 +02:00
William Desportes
a4bb90d4a8
Move level 0 into getNameForLevel0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 20:19:12 +02:00
William Desportes
b7494aaa62
Move level 1 into getNameForLevel1
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 19:13:18 +02:00
William Desportes
87d4a21164
Split some code in the Collation class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 19:12:35 +02:00
William Desportes
8e74c29baf
Merge #16153 - Fix #16102 - Broken error message
Pull-request: #16153
Fixes: #16102

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 18:33:01 +02:00
Petr Duda
37b22a5c71 Fix #16102 - Broken error message
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-31 17:41:49 +02:00
William Desportes
802797c176
Move getConnectionParams to Config class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 16:01:38 +02:00
William Desportes
36fa925914
Extract SQL query from DatabaseInterface::getColumnsFull
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 15:08:36 +02:00
William Desportes
73fb678d08
Extract SQL query from DatabaseInterface::getDatabasesFull
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 15:01:58 +02:00
William Desportes
ffcabac791
Simplify DatabaseInterface _fetchValue
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:54:33 +02:00
William Desportes
8e164bda85
Move _dbgQuery to Query\Utilities as debugLogQueryIntoSession
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:47:39 +02:00
William Desportes
eecab19b3e
Move versionToInt to Query\Utilities
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:18:03 +02:00
William Desportes
54e27c6a3d
Simplify DatabaseInterface fetchValue logic
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:17:01 +02:00
William Desportes
aadb6abfeb
Move usortComparisonCallback to Query\Utilities and remove 2 globals
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 10:34:02 +02:00
William Desportes
7e9d2ae4f9
Move more SQL queries into Query\Generator
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 02:16:02 +02:00
William Desportes
585304b685
Move formatError into Query\Utilities
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:44:02 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
William Desportes
312bf572f2
Move some compatibility handling into Query\Compatibility
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:26:07 +02:00
William Desportes
490d731d6c
Add some fallbacks if the data is not available
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:25:23 +02:00
William Desportes
a1a6dd99ea
Move vPath, aPath, pos to paths_nav using data-* attributes
Ref: d944f0851e
Ref: aec59d5007

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 00:58:16 +02:00
William Desportes
aec59d5007
Move pos3_name and pos3_value to pos3_nav using data-* attributes
Ref: d944f0851e

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 00:47:11 +02:00
William Desportes
d944f0851e
Move pos2_name and pos2_value to pos2_nav using data-* attributes
Note: data-* are standard attributes

I did not move the back-end part so it is easier to find the places to refactor calls

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 00:41:32 +02:00
William Desportes
928549a71b
Merge #16148 - Fix #16147 - php error after DBI code extraction
Fixes: #16147
Pull-request: #16148

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-30 22:38:43 +02:00
Maurício Meneghini Fauth
2937e9796d Remove underscore prefix from some method names
Related to #16149

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 17:20:43 -03:00
Maurício Meneghini Fauth
e29f892d62 Use consts to select the CodeGen handler format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:36:32 -03:00
Maurício Meneghini Fauth
e6b23cf9ef Fix TypeError in Util::getDbInfo
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
Maurício Meneghini Fauth
e2eac49ad2 Use closures to call private methods as callback
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
CommanderRoot
5a1c5acccc
Fix #16147
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-05-30 03:26:45 +02:00
Petr Duda
2eafc95c31
Translated using Weblate (Czech)
Currently translated at 97.7% (3259 of 3334 strings)

[CI skip]

Translation: phpMyAdmin/5.0
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/cs/
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-29 22:41:45 +02:00
Petr Duda
0271fcbbe8
Translated using Weblate (Czech)
Currently translated at 95.8% (3215 of 3355 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/cs/
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-29 22:41:37 +02:00
William Desportes
889715fefa
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-28 09:46:33 +02:00