gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,748 Commits 12 Branches 481 Tags 2.4 GiB
8bb312514e
Commit Graph

5249 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
8bb312514e
Merge pull request #18464 from kamil-tekiela/Refactor-parsePath 
More specific return type
 2023-05-29 23:20:36 -03:00
William Desportes
21cf996096
Merge #18462 - Code improvement: NullableCompareToNullRector 
Pull-request: #18462

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-29 13:05:51 +02:00
William Desportes
62a44a78bb
Merge #18465 - Use array shape for getPaths 
Pull-request: #18465

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-29 13:04:34 +02:00
Kamil Tekiela
a72ec07b68 Use array shape for getPaths 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-29 11:43:43 +01:00
Maurício Meneghini Fauth
920751a77a
Create the TriggerName value object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-28 15:46:59 -03:00
Kamil Tekiela
477e867cab More specific return type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-27 23:41:07 +01:00
Kamil Tekiela
f4f2f93b1c NullableCompareToNullRector 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-27 21:58:12 +01:00
Maurício Meneghini Fauth
1582b69591
Change Trigger::$table type to use TableName object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-27 16:17:21 -03:00
Maurício Meneghini Fauth
a2ed355faf
Add Timing enum for triggers action timing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-27 15:58:29 -03:00
Maurício Meneghini Fauth
7cdbfc2eaf
Add Event enum for trigger events 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-27 15:36:26 -03:00
Maurício Meneghini Fauth
ff7fe4bfa0
Extract getTables() method from Triggers::getEditorForm() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-26 20:29:23 -03:00
Maurício Meneghini Fauth
0d4b85552e
Add Trigger value object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-26 15:38:55 -03:00
Maurício Meneghini Fauth
5a344966a9
Move trigger row foreach loop into the list.twig template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 16:03:45 -03:00
Maurício Meneghini Fauth
81e988aac8
Inline Triggers::main() into the Triggers\IndexController 
The main() method is handling the request/response, so it's better to
move this code to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 15:40:16 -03:00
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers 
They are equivalent in current form.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
d006f2ae48
Fix blank DB tracking page when using control user 
The control user should not have permission to show tables.

See https://docs.phpmyadmin.net/en/latest/setup.html#manual-configuration
Related to https://github.com/phpmyadmin/phpmyadmin/pull/18259

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-24 22:47:38 -03:00
Maurício Meneghini Fauth
62ec1bcc2c
Merge pull request #18445 from kamil-tekiela/InsertEdit-pt4 
InsertEdit refactoring - part 4
 2023-05-24 21:16:01 -03:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2 
Replace superglobals with serverrequest in GetFieldController
 2023-05-24 15:31:24 -03:00
Maurício Meneghini Fauth
9e56194fc0
Fix issue with inline edit with multiple SQL message box 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-23 15:38:18 -03:00
Kamil Tekiela
7838a42a34 Move buildInsertSqlQuery to Generator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-23 15:31:46 +01:00
Kamil Tekiela
fa826f737a Implement InsertEditColumn 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-23 15:31:46 +01:00
Kamil Tekiela
90c0dc3b30 Remove unused params in IO plugins 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-23 15:31:46 +01:00
Kamil Tekiela
919bf36460 Move getColumnTitle() out of $column 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-23 15:31:46 +01:00
Kamil Tekiela
719bc91797 $column['values'] is never set anywhere 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-23 15:31:46 +01:00
Maurício Meneghini Fauth
30ff7d4b6a
Merge pull request #18434 from kamil-tekiela/InsertEdit-pt-3 
InsertEdit refactoring - part 3
 2023-05-23 11:02:09 -03:00
Maurício Meneghini Fauth
9b5d151d63
Improve Git::checkGitRevision() return type declaration 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-21 13:25:38 -03:00
Kamil Tekiela
43a864b50f Assign Default inside analyzeTableColumnsArray 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
1d180c5482 Use null as sentinel value in getColumn 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
0aa3210ee1 Use array shape instead of (string|null)[] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
0d9e795890 Narrow down type of SHOW COLUMNS 
MySQL clearly defines the structure of the fields for SHOW [FULL] COLUMNS. We can be sure it will be either string or null.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
2c9153ac5d Refactor column length calculation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:29:34 +01:00
Kamil Tekiela
3b611f3945 Implement ColumnFull DTO 
This is MVP. In following commits the DTO will be expanded and improved.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:29:34 +01:00
Kamil Tekiela
c4421d064d Improve type hint 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:29:34 +01:00
Kamil Tekiela
231ec1ba8b Remove QBE 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 11:21:46 +01:00
Maurício Meneghini Fauth
d6122696b5
Merge pull request #18432 from kamil-tekiela/ForeignKeyRelatedTable 
ForeignKeyRelatedTable DTO
 2023-05-18 20:54:32 -03:00
Maurício Meneghini Fauth
d0b219f063
Merge pull request #18427 from kamil-tekiela/voidify-loadIndexes 
Voidify loadIndexes
 2023-05-18 20:46:09 -03:00
Maurício Meneghini Fauth
2bf3cb587d
Merge pull request #18426 from kamil-tekiela/variableless-exceptions 
Don't catch exception into variable
 2023-05-18 20:45:12 -03:00
Maurício Meneghini Fauth
65dc549c35
Merge pull request #18425 from kamil-tekiela/Duplicated-line 
Remove duplicated line
 2023-05-18 20:43:35 -03:00
Maurício Meneghini Fauth
e1398f3402
Merge pull request #18424 from kamil-tekiela/Unused-params 
Remove unused params
 2023-05-18 20:30:57 -03:00
Maurício Meneghini Fauth
d362f79fa7
Merge pull request #18423 from kamil-tekiela/TableStatsEps-tableDraw 
Fix tableDraw in TableStatsEps
 2023-05-18 18:42:30 -03:00
Maurício Meneghini Fauth
0bf861dac7
Merge pull request #18421 from kamil-tekiela/versionToInt 
versionToInt never returns false
 2023-05-18 18:25:23 -03:00
Maurício Meneghini Fauth
1102858ba8
Redesign the SQL message card 
Fixes color issues for the dark color mode of the Bootstrap theme.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-17 22:31:50 -03:00
Maurício Meneghini Fauth
59131b58c8
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-17 16:17:48 -03:00
Maurício Meneghini Fauth
50bca5c1cb
Fix duplicate query params in the SQL message card 
Adds tests for the Html\Generator::getMessage() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-17 16:06:36 -03:00
Maurício Meneghini Fauth
1039557d83
Merge pull request #18422 from kamil-tekiela/narrow-types 
Narrow some mixed return types
 2023-05-17 14:50:43 -03:00
Kamil Tekiela
0dce80a459
Split Util::getSupportedDatatypes (#18420) 
* Split Util::getSupportedDatatypes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add test for getSupportedDatatypes

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-17 14:49:06 -03:00
Maurício Meneghini Fauth
e7d1ecbeae
Merge pull request #18419 from kamil-tekiela/UseIdenticalOverEqualWithSameTypeRector 
UseIdenticalOverEqualWithSameTypeRector
 2023-05-16 17:28:52 -03:00
Maurício Meneghini Fauth
78be90b34b
Merge pull request #18418 from kamil-tekiela/strlen 
Remove strlen in boolean conditions
 2023-05-16 17:23:58 -03:00
Kamil Tekiela
dfcceb1465 ForeignKeyRelatedTable 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-13 15:45:10 +01:00