Commit Graph

104415 Commits

Author SHA1 Message Date
Michal Čihař
ebda156932 The shared method has to be protected, not private
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 16:15:17 +01:00
Michal Čihař
a7bafe5a6c Share code for exporting routines and events to XML
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 16:08:32 +01:00
Michal Čihař
5801e7a019 Share _getPaperSizeArray code
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:57:34 +01:00
Michal Čihař
65aecc8e9e Test theme rendering
Tested for both built in themes.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:47:58 +01:00
Michal Čihař
d6546473c0 Add basic test for js messages
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:37:24 +01:00
Michal Čihař
ca59f5046c Use new contructor for Group() objects
This safes us next calls to setName and setText.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:26:52 +01:00
Michal Čihař
4975ef2bc2 Use new constructor for Item() objects
This allows to directly set name and text.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:04:02 +01:00
Michal Čihař
cd213039e8 Allow to specify name and text directly in OptionsPropertyItem contructor
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:04:02 +01:00
Marc Delisle
750af61ad5 Function was used before it was defined
Signed-off-by: Marc Delisle <marc@infomarc.info>
2016-01-05 08:42:31 -05:00
Michal Čihař
1168ed61b4 Share code for routines export
The exporting of functions and procedures is almost same.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 13:06:28 +01:00
Michal Čihař
c660edd057 Simplify code by removing parallel if statements
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:53:18 +01:00
Michal Čihař
063392e664 Merge branch 'QA_4_5' 2016-01-05 12:41:57 +01:00
Michal Čihař
fdcf305834 Fix operator placements and indentation
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:41:48 +01:00
Michal Čihař
a74efb0c30 Simplify getting first element of an array
Calling current() after reset() is duplicate as reset() already returns
current index value.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:37:50 +01:00
Michal Čihař
2bdd046b06 Remove not needed reset()
The variable is used only with foreach(), which does reset internally
(or uses different pointer with PHP 7).

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:33:39 +01:00
Michal Čihař
03f2e37ef4 Simplify code to get largest table
We really do not have to sort the array, we just need the maximal value.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:29:03 +01:00
Michal Čihař
c9b0935e7d Fix typo
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:18:05 +01:00
Michal Čihař
3c90f45020 Simplify shape record loading
We can use foreach with reference to simplify the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:18:05 +01:00
Michal Čihař
7f9333c3e1 Add second test for shape file import
This one contains multipolygons to test more complex things.

The data is based on OpenStreetMap, licensed under ODbL 1.0.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:18:05 +01:00
Michal Čihař
941325eb18 Close file only if it is opened
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:18:05 +01:00
Michal Čihař
65555e51d5 Ensure test can be executed separately
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:18:05 +01:00
Atul Pratap Singh
5ba197dc70 Merge branch 'QA_4_5' 2016-01-05 16:36:51 +05:30
Atul Pratap Singh
e4c194ccde Fix #11821 TypeError: $this_function.val(...) is null
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2016-01-05 16:32:22 +05:30
Michal Čihař
f4eb1a9b4f There is no need to reset() before foreach()
The code is there since past when PHP 4 was still supported reset was
necessary.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 11:26:34 +01:00
Michal Čihař
a37273c5ba Initialize array variables
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 11:07:51 +01:00
Michal Čihař
c2ea3bcc7d Build output in less steps
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 10:52:44 +01:00
Michal Čihař
4a3f055527 Free result only if it exists
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 09:12:19 +01:00
Michal Čihař
ea8382efcd Do not use case insensitive char for symbols lookup
These only add performance penatly at no benefit.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 09:09:57 +01:00
Michal Čihař
7973c2986e Better handle parse errors in GIS
The mb_stripos can return false and we should handle it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 09:08:29 +01:00
Michal Čihař
05b264564e Simplify indentation
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 09:07:29 +01:00
Michal Čihař
e0b1c1643e Close should not fail if open didn't
Hiding error on close is not needed, this should not happen unless the
system is really in a bad shape.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 09:05:01 +01:00
Michal Čihař
b66c189caf Document todo
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 09:03:00 +01:00
Michal Čihař
a7d2473025 Avoid ignoring error
There should be no error here as we've queried the result few lines ago.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 08:57:25 +01:00
Michal Čihař
592207946e Merge branch 'QA_4_5' 2016-01-05 08:38:19 +01:00
Michal Čihař
cedc7a442c Fix hiding of page content behind menu
We use jQuery to to the initializaton rather than directly overwriting
onload, which breaks other things,

Fixes #11820, #11812

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 08:35:57 +01:00
Weblate
e23ad2e57d Merge remote-tracking branch 'origin/master' 2016-01-05 08:23:16 +01:00
Masahiro Nishi
70b04acf37 Translated using Weblate (Japanese)
Currently translated at 66.6% (2144 of 3217 strings)

[CI skip]
2016-01-05 08:23:14 +01:00
Michal Čihař
991df753c7 Merge branch 'QA_4_5' 2016-01-05 08:21:42 +01:00
Michal Čihař
e1c9dec998 Merge commit '912f96114dc803404e2854ebb5796757a4eeedb6' 2016-01-05 08:21:32 +01:00
Michal Čihař
6d83b09840 Merge commit 'b16bec706a99b3058a14baffeef58470e59200a9' 2016-01-05 08:20:52 +01:00
Weblate
d6291c2f8f Merge remote-tracking branch 'origin/QA_4_5' into QA_4_5 2016-01-05 08:19:46 +01:00
Masahiro Nishi
e9d3ef465f Translated using Weblate (Japanese)
Currently translated at 67.4% (2166 of 3210 strings)

[CI skip]
2016-01-05 08:19:44 +01:00
Michal Čihař
912f96114d Merge pull request #11815 from nijel/dot-database
Fix handling of databases with dot in a name
2016-01-05 08:19:39 +01:00
Kiguda Kosuru
85d58a7fe8 Translated using Weblate (Japanese)
Currently translated at 65.9% (2121 of 3217 strings)

[CI skip]
2016-01-05 01:51:01 +01:00
Kiguda Kosuru
b16bec706a Translated using Weblate (Japanese)
Currently translated at 66.7% (2143 of 3210 strings)

[CI skip]
2016-01-05 01:50:55 +01:00
Michal Čihař
c197c3fba5 Fix handling of databases with dot in a name
We do not need to concatenate and parse the items, the cache backend
accepts array directly.

Fixes #11798

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 17:06:58 +01:00
Michal Čihař
66234c4521 Merge pull request #11768 from nijel/overload
Remove /*overload*/ prefix from mb_* calls
2016-01-04 16:57:06 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Deven Bansod
41caf7bafa Merge branch 'QA_4_5' 2016-01-04 19:43:01 +05:30
Deven Bansod
63fae992d8 ChangeLog entry for issue #11727
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-01-04 19:42:23 +05:30