Commit Graph

111039 Commits

Author SHA1 Message Date
Michal Čihař
580cb38562 We need to scroll relatively as getBoundingClientRect returns offset
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
2f13f070cb Ensure widgets are in the view
Scroll based on actuall widgets we target, not by arbitrary values.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
fa2457cf3d Simplify entering form values
Use value() instead of click() and keys().

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
11ff884f6a Remove sleeps from export tests
Those really should not be necessary or we should add some dynamic waits.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
2abb2db01d Remove sleep after scrollToBottom, should not be necessary
The javascript is executed synchronously, so there should be no delay.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
5c40939e74 Remove some no longer needed waits and sleeps
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
c3f8315858 Fixed waiting for event/procedure/trigger drop
The nothing2display element is always present, sometimes it is just
hidden. Wait for AJAX completion instead.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
037dde0e42 Share code for waiting for CodeMirror
It takes some time to initialize, so we should wait for it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
bbf84bd5f7 Remove strange wait loops
Those were most likely caused by wrong waiting on AJAX page load.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
c674ab8791 Try getting element directly in waitForElement
This can avoid 3 round trips to Selenium server in most situations, so
it can help performance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
eae223215a Run Chrome tests on Windows
It seems to perform way better with webdriver than OS X.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
eabdf845c3 Fix waiting for AJAX popup disappear in Selenium tests
Waiting for ajax_message_num_1 works only on first AJAX request and
we're doing more of them. This should remove need for many consequent
sleeps as we were actually not properly waiting for element.

Also it's better to wrap this logic in separate method as it is used in
many places in the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:17:06 +02:00
Michal Čihař
d083392dc9 Avoid checking links on software.opensuse.org
This seems to be broken quite often recently.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-07 15:07:05 +02:00
SacredWKnight
6b7c9d74d4 Translated using Weblate (Indonesian)
Currently translated at 79.4% (2566 of 3231 strings)

[CI skip]
2017-09-07 10:08:39 +02:00
Maurício Meneghini Fauth
456f285baf Merge pull request #13661 from mauriciofauth/server-status-monitor
Refactor server_status_monitor functions to static methods
2017-09-06 18:47:37 -03:00
Maurício Meneghini Fauth
97c2ebdade Merge pull request #13658 from mauriciofauth/display-import
Refactor display_import functions to static methods
2017-09-06 18:47:05 -03:00
Kristjan Räts
76d449b04b Translated using Weblate (Estonian)
Currently translated at 100.0% (3231 of 3231 strings)

[CI skip]
2017-09-06 21:59:26 +02:00
Maurício Meneghini Fauth
23c2b1189b Refactor server_status_monitor to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-06 15:33:53 -03:00
Michal Čihař
b9b6b45a4f Use nginx for running Selenium tests
It is supposed to perform better than PHP built in server.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 19:19:07 +02:00
Michal Čihař
fddf289f55 Silent possible warnings from open basedir
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 19:18:50 +02:00
Michal Čihař
f8095a6825 Correctly handle failures on early init
We can not use Response without dbi link.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 17:31:06 +02:00
Weblate
bcbf1c1ac1 Merge remote-tracking branch 'origin/master' 2017-09-06 16:17:11 +02:00
eisenhaus335
08ff3ee7fd Translated using Weblate (Indonesian)
Currently translated at 79.2% (2559 of 3231 strings)

[CI skip]
2017-09-06 16:17:08 +02:00
Michal Čihař
0b384529e8 Merge pull request #13656 from nijel/dbi-cleanup
Various cleanups in DBI
2017-09-06 16:16:43 +02:00
Maurício Meneghini Fauth
f0f8c3e68f Refactor display_import functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-06 10:59:18 -03:00
Michal Čihař
ad99c4ac4b Remove unused define PMA_MYSQL_CLIENT_API
Remove PMA_MYSQL_CLIENT_API and all logic for defining it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 14:46:57 +02:00
Michal Čihař
a82f8fc768 Move databaase interface load to static method
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 14:46:56 +02:00
Michal Čihař
bc6486e2e0 Move mysqli flag description sot Dbi class
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 14:46:56 +02:00
Michal Čihař
6bd94464c8 Merge pull request #13648 from nijel/hash-dependency
Make hash extension required
2017-09-06 14:10:10 +02:00
Maurício Meneghini Fauth
503a711af2 Merge pull request #13655 from mauriciofauth/normalization
Refactor normalization functions to static methods
2017-09-06 07:22:53 -03:00
Michal Čihař
403b7ab72b Merge branch 'forms' 2017-09-06 12:03:57 +02:00
Michal Čihař
e900f55929 Merge branch 'QA_4_7' 2017-09-06 12:03:54 +02:00
Māris
8780ae073e Translated using Weblate (Latvian)
Currently translated at 17.9% (574 of 3205 strings)

[CI skip]
2017-09-06 12:03:27 +02:00
Māris
8c30b3be14 Translated using Weblate (Latvian)
Currently translated at 17.6% (571 of 3231 strings)

[CI skip]
2017-09-06 12:03:26 +02:00
Michal Čihař
bea182257b Add test for UserprefsDeveloperTab
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 12:02:39 +02:00
Michal Čihař
35fca8e2d5 Remove not used BaseFormList::getDefault
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 12:00:17 +02:00
Michal Čihař
4ec970fc82 Remove duplicite validation
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:59:41 +02:00
Michal Čihař
3559f7a8a5 Remove special casing for UserprefsDeveloperTab
- include it in user form only if allowed
- always include it in setup form

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:06:51 +02:00
Michal Čihař
e065793dc8 Fold validity check with getting class
There is no need to do this twice (once in ::get).

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:06:51 +02:00
Michal Čihař
5788613cbc Use form name for menu in user preferences
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:10 +02:00
Michal Čihař
953ef05b92 Use forms to define menu and titles on setup
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:10 +02:00
Michal Čihař
8490161073 Share code for testing FormLists
The tests were same anyway, so avoid duplicating code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:10 +02:00
Michal Čihař
09642df6fc Avoid using abstract static functions
This does not work in PHP 5, only in PHP 7.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:09 +02:00
Michal Čihař
8490d3a571 Rewrite Setup settings forms as classes
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:09 +02:00
Michal Čihař
1fb2887a2a Bring User settings in sync with Setup
- add server navigation configuration, it makes no sense to hide this
  from user as it configures just UI
- reorganize Features form a bit to be in sync with Setup
- add DisableShortcutKeys settings to User
- remove LoginCookieValidity from User settings (there are more cookie
  related settings and all should be handled same)

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:09 +02:00
Michal Čihař
94bb2e31a1 Remove no longer needed page_settings.forms.php and user_preferences.forms.php
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:04:47 +02:00
Michal Čihař
73d1599a1a Rewrite Page settings forms as classes
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:02:07 +02:00
Michal Čihař
df7f328f79 Rewrite User preferences forms as clases
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:02:07 +02:00
Maurício Meneghini Fauth
67e7711368 Refactor normalization functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-05 23:03:43 -03:00
Maurício Meneghini Fauth
0182146c49 Merge pull request #13653 from mauriciofauth/db-designer
Refactor db_designer functions to static methods
2017-09-05 19:08:43 -03:00