Commit Graph

127945 Commits

Author SHA1 Message Date
Kamil Tekiela
62fac42bd8 Improve code quality
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-27 15:08:09 +01:00
Kamil Tekiela
7373b58cd5 Remove trigger_error from getStatusInfo()
This is a custom undefined index error, which is a developer error, not a runtime error. It should be enforced in the code, and should not throw a user error.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-27 15:02:23 +01:00
Kamil Tekiela
01aaa90861 Remove $_SESSION['is_multi_query']
It's not clear what this was supposed to do, but it definitely shouldn't be done this way.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-27 14:49:28 +01:00
Kristijan \"Fremen\" Velkovski
0dbb5d714c
Translated using Weblate (Macedonian)
Currently translated at 26.7% (912 of 3411 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>
2023-12-26 23:01:36 +01:00
Maurício Meneghini Fauth
f9ecf7d369
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-26 16:55:31 -03:00
Maurício Meneghini Fauth
98ee8f7158
Merge pull request #18862 from MauricioFauth/server-global
Replace server global with Current::$server
2023-12-24 17:48:28 -03:00
Maurício Meneghini Fauth
31419bc770
Merge pull request #18859 from kamil-tekiela/getDbInfo
Refactor getDbInfo() and getTablesWhenOpen()
2023-12-24 03:47:51 -03:00
Maurício Meneghini Fauth
e53c76d179
Merge pull request #18857 from kamil-tekiela/SqlAutoCompleteController
New implementation for SqlAutoCompleteController
2023-12-24 03:06:39 -03:00
Maurício Meneghini Fauth
f43da40442
Merge pull request #18856 from kamil-tekiela/getTablesFull
Refactoring of getTablesFull and Query/Cache
2023-12-24 03:04:13 -03:00
Maurício Meneghini Fauth
1129750eee
Replace server global with Current::$server
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-24 02:08:50 -03:00
Kristijan \"Fremen\" Velkovski
07e0c48467
Translated using Weblate (Macedonian)
Currently translated at 27.8% (954 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>
2023-12-24 03:07:43 +00:00
Hosted Weblate
597d2ee96e
Merge branch 'origin/master' into Weblate.
[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/
2023-12-24 01:19:40 +01:00
Kristijan \"Fremen\" Velkovski
0c18b5e567
Translated using Weblate (Macedonian)
Currently translated at 26.6% (908 of 3411 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>
2023-12-24 01:19:40 +01:00
phpMyAdmin bot
92cf05f5b1 Update po files
[ci skip]

Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2023-12-24 00:19:25 +00:00
Maurício Meneghini Fauth
76f2341f41
Merge pull request #18854 from kamil-tekiela/More-Designer-fixes
More Designer refactorings
2023-12-23 21:02:45 -03:00
Maurício Meneghini Fauth
b7efa525d8
Merge pull request #18858 from kamil-tekiela/Optimize-MultiTableQuery
Optimize MultiTableQuery
2023-12-23 20:26:42 -03:00
Kristijan \"Fremen\" Velkovski
759e053eef
Translated using Weblate (Macedonian)
Currently translated at 26.5% (905 of 3411 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>
2023-12-23 02:09:57 +01:00
Maurício Meneghini Fauth
0634b67c09
Merge pull request #18860 from MauricioFauth/container
Decouple from Symfony's container
2023-12-22 21:18:27 -03:00
Maurício Meneghini Fauth
e642378f41
Merge pull request #18861 from kamil-tekiela/Final-controllers
Make some controllers final
2023-12-22 19:28:07 -03:00
Maurício Meneghini Fauth
74054cb4d3
Extract container builder logic to ContainerBuilder class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-22 19:22:18 -03:00
Kamil Tekiela
435da9cc4d Remove property redefinitions
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-22 13:51:00 +01:00
Kamil Tekiela
b3276b39c3 Make BinlogController final
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-22 13:46:08 +01:00
Kamil Tekiela
49149b218d Make StructureController final
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-22 13:42:57 +01:00
Maurício Meneghini Fauth
033dcf21e0
Change Core::getContainerBuilder return to ContainerInterface
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-21 16:46:11 -03:00
Maurício Meneghini Fauth
81f32fe16e
Remove dbi from UrlRedirector
Is not necessary to set the DatabaseInterface instance. The container
builder will correctly instanciate it if necessary.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-21 15:11:34 -03:00
Kamil Tekiela
7dc661c96c Remove $tables variable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-21 15:33:22 +01:00
Kamil Tekiela
d4f8e2683f Optimize MultiTableQuery
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-21 15:15:18 +01:00
Maurício Meneghini Fauth
d2d347fbb2
Remove container from Database\StructureControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 22:24:43 -03:00
Maurício Meneghini Fauth
3d83c62fa3
Remove AbstractTestCase::loadResponseIntoContainerBuilder()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 22:06:39 -03:00
Maurício Meneghini Fauth
0ef906be5d
Remove container from MultiTableQuery\TablesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 21:51:41 -03:00
Maurício Meneghini Fauth
a9db702639
Remove container from Table\SearchControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 21:42:50 -03:00
Maurício Meneghini Fauth
f5ebc2355b
Remove container from NavigationControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 21:35:49 -03:00
Maurício Meneghini Fauth
c229b98f76
Remove container from Sql\EnumValuesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 21:13:54 -03:00
Kristijan \"Fremen\" Velkovski
9c813038e6
Translated using Weblate (Macedonian)
Currently translated at 26.5% (904 of 3411 strings)

[ci skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>
2023-12-21 00:46:57 +01:00
Kristijan \"Fremen\" Velkovski
a03767ca9c
Translated using Weblate (Macedonian)
Currently translated at 27.7% (952 of 3427 strings)

[ci skip]

Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>
2023-12-21 00:46:45 +01:00
Maurício Meneghini Fauth
1245c976ee
Remove container from Sql\SetValuesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 20:45:13 -03:00
Maurício Meneghini Fauth
bbebcbf970
Remove container from Operations\TableControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 20:16:14 -03:00
Kamil Tekiela
c2179c9482 Use count outside of getDbInfo()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 23:57:09 +01:00
Kamil Tekiela
26bb95f4fd Refactor getTablesWhenOpen
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 23:56:44 +01:00
Kamil Tekiela
bb68c5f87c Privatize method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 23:56:44 +01:00
Maurício Meneghini Fauth
e852380e7e
Remove container from Import\ImportControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 17:16:22 -03:00
Kamil Tekiela
cfe88447bc Remove unnecessary force reads of table status
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
e7cc859d7d Instead of rereading, clear cache
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
1c9831f1ed Simplify code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
ae78224190 Simplify return statement
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
a4f09239d5 Fix wrong comparison operator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
efbfe24348 Narrow down types in Cache
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
5e24fb8a52 Replace cacheTableContent with cacheTableValue
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
d90f31f67c Remove nullable param
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
6869fb9e3e Remove dead code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:02 +01:00