Kamil Tekiela
8d7e3e2229
Simplified switch
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
8d06fda694
Remove redundant operations
...
These are noop anyway.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
29a055b497
Remove redundant cast during concat
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:44 +00:00
Kamil Tekiela
99f37f4b7b
Remove redundant is_array check
...
It's always array because of `if (empty($view['name']))` check
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:23:35 +00:00
Kamil Tekiela
47d9ad9b23
Remove always false $_error
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 17:17:47 +00:00
Maurício Meneghini Fauth
47238d6c8c
Fix ImportController failing test and other minor fixes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-14 13:33:37 -03:00
ru-asdx
3794031ebc
Ref #17769 - Replace superglobals with ServerRequest in Import & Export Controllers ( #17949 )
...
* Replace superglobals with ServerRequest in Import & Export Controllers
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
* small fixes
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
* fixes
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2022-12-14 12:04:38 -03:00
Kamil Tekiela
a84cae6c2d
Refactor ExportSql - part 1 ( #17955 )
...
* Add getTableStatus method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unused $errorUrl parameter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unused parameter $table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Add string return types
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Refactor exportUseStatement
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Specify param types for exportConfigurationMetadata
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* param types for getTableDefForView
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Param types for getTableComments
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Small fixes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Extract addCompatOptions() method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove no longer needed suppress
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Merge if statements by SonarLint
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update phpstan-baseline.neon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Specify param types for exportRoutineSQL
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Specify param types for generateComment
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Specify param types for replaceWithAliases
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update psalm-baseline.xml
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-14 11:56:22 -03:00
Kristijan Fremen Velkovski
9e31295234
Translated using Weblate (Serbian (latin))
...
Currently translated at 38.9% (1339 of 3434 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/sr_Latn/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-12-13 21:50:34 +01:00
Kamil Tekiela
6ae40562e5
Remove globals from ExportController ( #17948 )
...
* Remove globals from Export controller
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* filename_template
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* export_plugin
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* compression_methods
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* onserver
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* quick_export
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* remember_template
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* mime_type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* do_relation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* doComments
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* do_mime
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* do_dates
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* whatStrucOrData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* db_select
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* table_structure
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* lock_tables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* allrows
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Update ExportController.php
* limit_to
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Update ExportController.php
Update ExportController.php
* limit_from
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unused globals
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* $GLOBALS['filename'] in ManageController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* filename
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update psalm-baseline.xml
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update phpstan-baseline.neon
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-13 12:09:56 -03:00
Kamil Tekiela
f783bdea6c
Change variable name case
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-13 09:47:30 -03:00
Kamil Tekiela
7c1bfec7f5
Removal of globals
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-13 09:43:01 -03:00
Maurício Meneghini Fauth
4e40aef04f
Extract CommonActions.refreshMain into a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-12 19:59:04 -03:00
Maurício Meneghini Fauth
94b9c9b723
Extract Functions.checkNumberOfFields() into a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-12 14:24:28 -03:00
Kristijan Fremen Velkovski
92c0b4f961
Translated using Weblate (Macedonian)
...
Currently translated at 23.5% (809 of 3434 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-12-12 09:47:31 +01:00
Maurício Meneghini Fauth
1cd484e1bc
Extract Functions.handleRedirectAndReload() into a module
...
This removes the dependency on Functions in navigation.js.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-11 21:19:44 -03:00
Maurício Meneghini Fauth
b3e40101ee
Remove callback param from CommonActions.refreshMain()
...
This removes the dependency on AJAX in common.js file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-11 18:20:34 -03:00
Maurício Meneghini Fauth
0160f0a8c6
Remove unused CommonActions.openDb() function
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-11 17:23:08 -03:00
Hosted Weblate
0fa9a95aa1
Merge branch 'origin/master' into Weblate.
...
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/
2022-12-11 01:21:15 +01:00
Kristijan Fremen Velkovski
d1af9671fc
Translated using Weblate (Macedonian)
...
Currently translated at 23.5% (808 of 3434 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-12-11 01:21:13 +01:00
Marc Delisle
7e1266dbba
Translated using Weblate (French)
...
Currently translated at 100.0% (3434 of 3434 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/fr/
Signed-off-by: Marc Delisle <marc@infomarc.info>
2022-12-11 01:21:13 +01:00
phpMyAdmin bot
89d27aa94b
Update po files
...
[ci skip]
Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>
2022-12-11 00:20:49 +00:00
Maurício Meneghini Fauth
729b21b911
Extract Functions.ignorePhpErrors() into a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 19:24:20 -03:00
Maurício Meneghini Fauth
cdd2d42e7f
Extract Functions.getImage() into a module
...
Renames it to getImageTag().
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 19:07:26 -03:00
Maurício Meneghini Fauth
21350eecab
Merge pull request #17954 from lem9/patch-2
...
Improve wording
2022-12-10 19:05:29 -03:00
Maurício Meneghini Fauth
631bb23128
Extract Functions.escape* into a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 18:33:38 -03:00
Kamil Tekiela
78e3f495cd
Replace escapeString with quoteString
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-10 17:56:11 -03:00
Marc Delisle
269e7536ad
Improve wording
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2022-12-10 15:50:02 -05:00
Maurício Meneghini Fauth
56d8f70641
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 17:47:31 -03:00
Maurício Meneghini Fauth
0314730ec2
Bump actions/upload-artifact version to v3
...
Cherry-picks 3343bf54f5 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 17:45:36 -03:00
Maurício Meneghini Fauth
3343bf54f5
Upload screenshots only for failed Selenium tests
...
Successful tests doesn't produce screenshots.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 17:40:49 -03:00
Maurício Meneghini Fauth
158b44e9e2
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 17:20:43 -03:00
Maurício Meneghini Fauth
5fc2887448
Add PHP 8.2 to test workflow matrix
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 17:15:50 -03:00
Maurício Meneghini Fauth
977ffae0ae
Fix broken GIS tests by using fixed version of TCPDF
...
This is caused by the PDF Producer metadata that is different for each
version of TCPDF causing the tests to fail, as the reference PDFs are
generated using TCPDF 6.5.0.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 16:59:56 -03:00
MoonE
5116b0f0fe
Simplify gis polygon handling ( #17904 )
...
* 'Expected' is first param for assertEquals
* Do direct string comparisons with gis svg test
Ids are not random during tests.
* Test gis png and pdf output
* Add pdf for i386 architecter, points are slightly different
* No special handling for inner and outer rings
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2022-12-10 15:09:40 -03:00
Maurício Meneghini Fauth
283d427cd9
Extract Functions.getJsConfirmCommonParam() into a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-09 20:02:27 -03:00
Kristijan Fremen Velkovski
6cae71709a
Translated using Weblate (Macedonian)
...
Currently translated at 23.3% (802 of 3434 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-12-09 23:50:34 +01:00
Kristijan Fremen Velkovski
ea347037ac
Translated using Weblate (Macedonian)
...
Currently translated at 23.4% (801 of 3418 strings)
[ci skip]
Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-12-09 23:49:09 +01:00
Maurício Meneghini Fauth
ea2dc6664a
Extract Functions.createProfilingChart() into a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-09 15:57:30 -03:00
Maurício Meneghini Fauth
2cf3f49f35
Remove indexes column lists from Window object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-09 11:52:49 -03:00
Maurício Meneghini Fauth
75dbb2cfd2
Extract Functions.config* to a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-09 11:10:26 -03:00
Maurício Meneghini Fauth
5348e09627
Extract Functions.createViewModal() to a module
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-09 10:47:43 -03:00
Kristijan Fremen Velkovski
f2ff55f605
Translated using Weblate (Macedonian)
...
Currently translated at 23.1% (796 of 3434 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-12-08 09:48:36 +01:00
Emanuel
03905a2f21
Translated using Weblate (Romanian)
...
Currently translated at 91.2% (3134 of 3434 strings)
[ci skip]
Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ro/
Signed-off-by: Emanuel <emanuel12m@gmail.com>
2022-12-08 09:48:35 +01:00
Emanuel
cdb4259b9e
Translated using Weblate (Romanian)
...
Currently translated at 91.8% (3139 of 3418 strings)
[ci skip]
Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ro/
Signed-off-by: Emanuel <emanuel12m@gmail.com>
2022-12-08 09:47:13 +01:00
Kristijan Fremen Velkovski
2f9da32860
Translated using Weblate (Macedonian)
...
Currently translated at 23.2% (795 of 3418 strings)
[ci skip]
Translation: phpMyAdmin/5.2
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/
Signed-off-by: Kristijan Fremen Velkovski <me@krisfremen.com>
2022-12-08 09:47:12 +01:00
William Desportes
90b30946d4
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-07 13:14:08 +01:00
William Desportes
a08f2567b5
Add --no-interaction and --dev on create_phpunit_sandbox function to create a release
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-12-07 13:07:22 +01:00
Maurício Meneghini Fauth
ce5ce76a8d
Merge pull request #17950 from MauricioFauth/ajax-messages
...
Extract Functions.ajaxShowMessage() into ajax-messages.js
2022-12-06 12:17:22 -03:00
Maurício Meneghini Fauth
3bc3c7de4d
Extract Functions.ajaxShowMessage() into ajax-messages.js
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-06 08:21:58 -03:00